Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2803663002: s390: fix s390 release for not generate mul opt (Closed)

Created:
3 years, 8 months ago by john.yan
Modified:
3 years, 8 months ago
Reviewers:
JoranSiu, JaideepBajwa
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

s390: fix s390 release for not generate mul opt DCHECK disappears on release build. R=joransiu@ca.ibm.com, bjaideep@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/2803663002 Cr-Commit-Position: refs/heads/master@{#44413} Committed: https://chromium.googlesource.com/v8/v8/+/639f44d4732ed5b79564a77621059620e36bcf3a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M src/compiler/s390/instruction-selector-s390.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
JaideepBajwa
lgtm
3 years, 8 months ago (2017-04-05 13:19:20 UTC) #1
JoranSiu
On 2017/04/05 13:19:20, JaideepBajwa wrote: > lgtm lgtm
3 years, 8 months ago (2017-04-05 13:22:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803663002/1
3 years, 8 months ago (2017-04-05 13:24:08 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 13:47:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/639f44d4732ed5b79564a77621059620e36...

Powered by Google App Engine
This is Rietveld 408576698