Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2803653003: MD Downloads: improve early loading shim (Closed)

Created:
3 years, 8 months ago by Dan Beam
Modified:
3 years, 8 months ago
Reviewers:
esprehn
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-downloads_chromium.org, David Trainor- moved to gerrit, michaelpg+watch-md-ui_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: improve early loading shim Copy some colors, actually simulate the toolbar. Generally make things super fast. R=esprehn@chromium.org BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2803653003 Cr-Commit-Position: refs/heads/master@{#462710} Committed: https://chromium.googlesource.com/chromium/src/+/c27e1094ac8d13391b7e6783bab1f1b49223a7e2

Patch Set 1 : asdf #

Total comments: 1

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M chrome/browser/resources/md_downloads/downloads.html View 1 1 chunk +8 lines, -4 lines 0 comments Download
M chrome/browser/resources/md_downloads/item.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_downloads/manager.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/md_downloads/manager.js View 1 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_downloads/toolbar.html View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
Dan Beam
3 years, 8 months ago (2017-04-06 03:34:08 UTC) #3
esprehn
Avoid attribute selectors whenever possible, they're largely a footgun and slow. https://codereview.chromium.org/2803653003/diff/20001/chrome/browser/resources/md_downloads/downloads.html File chrome/browser/resources/md_downloads/downloads.html (right): ...
3 years, 8 months ago (2017-04-06 03:46:47 UTC) #6
Dan Beam
attrs->classes
3 years, 8 months ago (2017-04-06 04:05:44 UTC) #7
esprehn
lgtm
3 years, 8 months ago (2017-04-07 00:03:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803653003/40001
3 years, 8 months ago (2017-04-07 00:06:41 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 00:36:37 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c27e1094ac8d13391b7e6783bab1...

Powered by Google App Engine
This is Rietveld 408576698