Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2803643004: [turbofan] reenable: extend escape analysis to reduce CheckMaps (Closed)

Created:
3 years, 8 months ago by Tobias Tebbi
Modified:
3 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] reenable: extend escape analysis to reduce CheckMaps R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2803643004 Cr-Commit-Position: refs/heads/master@{#44461} Committed: https://chromium.googlesource.com/v8/v8/+/25aff3448eb1813702d098361437a7e88256a1c1

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -25 lines) Patch
M src/compiler/escape-analysis.cc View 1 chunk +22 lines, -25 lines 1 comment Download

Messages

Total messages: 9 (3 generated)
Tobias Tebbi
3 years, 8 months ago (2017-04-06 13:42:18 UTC) #1
Tobias Tebbi
https://codereview.chromium.org/2803643004/diff/1/src/compiler/escape-analysis.cc File src/compiler/escape-analysis.cc (left): https://codereview.chromium.org/2803643004/diff/1/src/compiler/escape-analysis.cc#oldcode1532 src/compiler/escape-analysis.cc:1532: if (FLAG_turbo_experimental) { Why doesn't it ignore whitespace? This ...
3 years, 8 months ago (2017-04-06 13:45:17 UTC) #2
Benedikt Meurer
LGTM! Let's see what happens, and act only if we need to act.
3 years, 8 months ago (2017-04-06 14:33:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803643004/1
3 years, 8 months ago (2017-04-06 20:16:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/25aff3448eb1813702d098361437a7e88256a1c1
3 years, 8 months ago (2017-04-06 21:02:30 UTC) #8
Tobias Tebbi
3 years, 8 months ago (2017-04-10 11:04:28 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2811693002/ by tebbi@chromium.org.

The reason for reverting is: canary crashes.

Powered by Google App Engine
This is Rietveld 408576698