Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2803623002: Fetch favicon for ReadingListItem (Closed)

Created:
3 years, 8 months ago by gambard
Modified:
3 years, 8 months ago
Reviewers:
lpromero
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fetch favicon for ReadingListItem The ContentSuggestionsUpdater now fetches the favicon for the ReadingListItems. BUG=706296 Review-Url: https://codereview.chromium.org/2803623002 Cr-Commit-Position: refs/heads/master@{#462426} Committed: https://chromium.googlesource.com/chromium/src/+/8168c8dd3b54ae05890afeeaca934acda86ce7ff

Patch Set 1 #

Patch Set 2 : Factor methods #

Patch Set 3 : Add comment #

Total comments: 2

Patch Set 4 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -16 lines) Patch
M ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm View 1 2 3 3 chunks +48 lines, -16 lines 0 comments Download

Depends on Patchset:

Issue 2796273002 Patch 40001

Messages

Total messages: 10 (5 generated)
gambard
PTAL.
3 years, 8 months ago (2017-04-05 12:22:24 UTC) #2
lpromero
lgtm https://codereview.chromium.org/2803623002/diff/40001/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm File ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm (right): https://codereview.chromium.org/2803623002/diff/40001/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm#newcode473 ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm:473: // Returns a reading list item build with ...
3 years, 8 months ago (2017-04-05 13:14:14 UTC) #3
gambard
Thanks! https://codereview.chromium.org/2803623002/diff/40001/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm File ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm (right): https://codereview.chromium.org/2803623002/diff/40001/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm#newcode473 ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm:473: // Returns a reading list item build with ...
3 years, 8 months ago (2017-04-06 11:17:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803623002/60001
3 years, 8 months ago (2017-04-06 11:18:08 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 11:31:45 UTC) #10
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8168c8dd3b54ae05890afeeaca93...

Powered by Google App Engine
This is Rietveld 408576698