Removing support for document.createEvent("ProgressEvent")

Removing support for document.createEvent("ProgressEvent")

BUG=703559
Review-Url: https://codereview.chromium.org/2803603003
Cr-Commit-Position: refs/heads/master@{#464378}
Committed: https://chromium.googlesource.com/chromium/src/+/a5d70ebb214f8d77c943c98f1e2908c91b3d62b7

[nikhil.sahni, 2017-04-06 06:12:19]

Description was changed from

==========
Removing support for creating ProgressEvent.

Removing support for document.createEvent("ProgressEvent").

BUG=703559
==========

to

==========
Removing support for creating ProgressEvent.

Removing support for document.createEvent("ProgressEvent").

BUG=703559

R=SamsungPeerReview
==========

[nikhil.sahni, 2017-04-06 06:12:19]

nikhil.sahni@samsung.com changed reviewers:
+ shanmuga.m@samsung.com, srirama.m@samsung.com

[Srirama, 2017-04-06 06:40:48]

Peer review looks good.

[nikhil.sahni, 2017-04-06 06:43:21]

Description was changed from

==========
Removing support for creating ProgressEvent.

Removing support for document.createEvent("ProgressEvent").

BUG=703559

R=SamsungPeerReview
==========

to

==========
Removing support for creating ProgressEvent.

Removing support for document.createEvent("ProgressEvent").

BUG=703559
==========

[nikhil.sahni, 2017-04-06 06:43:21]

nikhil.sahni@samsung.com changed reviewers:
+ foolip@chromium.org, tkent@chromium.org

[foolip, 2017-04-06 09:07:36]

Description was changed from

==========
Removing support for creating ProgressEvent.

Removing support for document.createEvent("ProgressEvent").

BUG=703559
==========

to

==========
Removing support for document.createEvent("ProgressEvent")

BUG=703559
==========

[foolip, 2017-04-06 09:07:56]

I changed the title/description to be clear that it's only about
document.createEvent("ProgressEvent")

[foolip, 2017-04-06 09:10:16]

Code LGTM, just need to agree about paperwork.

This is such a minor thing that I think we should bypass the Intent to
Deprecate/Remove process, and just create a chromestatus.com entry for it.
tkent@, WDYT?

https://codereview.chromium.org/2803603003/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/build/scripts/make_event_factory.py (left):

https://codereview.chromium.org/2803603003/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/build/scripts/make_event_factory.py:89: or name ==
'ProgressEvent'
Also remove DocumentCreateEventProgressEvent from UseCounter.h.

[foolip, 2017-04-06 09:10:28]

Use counter at
https://www.chromestatus.com/metrics/feature/timeline/popularity/1177

[tkent, 2017-04-06 09:11:47]

> This is such a minor thing that I think we should bypass the Intent to
Deprecate/Remove process, and just create a chromestatus.com entry for it.
tkent@, WDYT?

I agree.  chromestatus.com entry is necessary anyway.

[foolip, 2017-04-06 09:20:44]

In an httparchive search for REGEXP_MATCH(body,
r'(?i:createEvent.{2,10}progressevent)') I find only 3 sites that call
createEvent("ProgressEvent"):

http://www.shgs.ru/
https://www.kinokopilka.pro/
https://www.off---white.com/en/VN

For all three, it's followed by a call to initProgressEvent, which doesn't
exist, so the code will throw an exception. With this removed, it'll just throw
the exception earlier.

[nikhil.sahni, 2017-04-06 10:26:26]

Addressed the Review Comments.

https://codereview.chromium.org/2803603003/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/build/scripts/make_event_factory.py (left):

https://codereview.chromium.org/2803603003/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/build/scripts/make_event_factory.py:89: or name ==
'ProgressEvent'
On 2017/04/06 09:10:16, foolip_UTC7 wrote:
> Also remove DocumentCreateEventProgressEvent from UseCounter.h.

Done.

[nikhil.sahni, 2017-04-06 10:26:26]

Addressed the Review Comments.

https://codereview.chromium.org/2803603003/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/build/scripts/make_event_factory.py (left):

https://codereview.chromium.org/2803603003/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/build/scripts/make_event_factory.py:89: or name ==
'ProgressEvent'
On 2017/04/06 09:10:16, foolip_UTC7 wrote:
> Also remove DocumentCreateEventProgressEvent from UseCounter.h.

Done.

[nikhil.sahni, 2017-04-06 10:26:26]

Addressed the Review Comments.

https://codereview.chromium.org/2803603003/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/build/scripts/make_event_factory.py (left):

https://codereview.chromium.org/2803603003/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/build/scripts/make_event_factory.py:89: or name ==
'ProgressEvent'
On 2017/04/06 09:10:16, foolip_UTC7 wrote:
> Also remove DocumentCreateEventProgressEvent from UseCounter.h.

Done.

[foolip, 2017-04-06 10:32:45]

Hmm, so in
https://groups.google.com/a/chromium.org/d/msg/blink-dev/BkPSl0Oey8k/BqJ3_ck0...
I didn't create a chromestatus.com entry for a much bigger change of this sort.

I think that one entry per supported string we remove isn't going to be very
useful. I'll ask Joe Medley what he thinks and report back here.

[nikhil.sahni, 2017-04-10 05:09:50]

Hi Philip,

do I need to do anything for this or its under progress.

Thanks

[foolip, 2017-04-10 06:09:23]

On 2017/04/10 05:09:50, nikhil.sahni wrote:
> Hi Philip,
> 
> do I need to do anything for this or its under progress.
> 
> Thanks

No reply from Joe, so please create a chromestatus.com entry.

[foolip, 2017-04-11 17:30:02]

On 2017/04/10 06:09:23, foolip_UTC7 wrote:
> On 2017/04/10 05:09:50, nikhil.sahni wrote:
> > Hi Philip,
> > 
> > do I need to do anything for this or its under progress.
> > 
> > Thanks
> 
> No reply from Joe, so please create a http://chromestatus.com entry.

Strike that, per email Joe says that won't be necessary, because support for
document.createEvent("ProgressEvent") doesn't seem to ever have been documented
anywhere.

Which means that this CL LGTM. tkent@, do you have anything further?

[nikhil.sahni, 2017-04-12 07:26:13]

On 2017/04/11 17:30:02, foolip_UTC7 wrote:
> On 2017/04/10 06:09:23, foolip_UTC7 wrote:
> > On 2017/04/10 05:09:50, nikhil.sahni wrote:
> > > Hi Philip,
> > > 
> > > do I need to do anything for this or its under progress.
> > > 
> > > Thanks
> > 
> > No reply from Joe, so please create a http://chromestatus.com entry.
> 
> Strike that, per email Joe says that won't be necessary, because support for
> document.createEvent("ProgressEvent") doesn't seem to ever have been
documented
> anywhere.
> 
> Which means that this CL LGTM. tkent@, do you have anything further?

Ok Philip, thanks will wait for tkent's reply.

[tkent, 2017-04-13 00:51:27]

> > > No reply from Joe, so please create a http://chromestatus.com entry.
> > 
> > Strike that, per email Joe says that won't be necessary, because support for
> > document.createEvent("ProgressEvent") doesn't seem to ever have been
documented
> > anywhere.
> > 
> > Which means that this CL LGTM. tkent@, do you have anything further?
> 
> Ok Philip, thanks will wait for tkent's reply.

I prefer making chromestatus.com entry even in this case, but you may skip it.

[nikhil.sahni, 2017-04-13 07:49:36]

Hi Philip,

Plz do let me know on this.

Thanks

[foolip, 2017-04-13 08:41:11]

On 2017/04/13 07:49:36, nikhil.sahni wrote:
> Hi Philip,
> 
> Plz do let me know on this.
> 
> Thanks

Since I skipped a chromestatus.com entry for a very similar situation and Joe is
OK with that, feel free to land. If you'd like to create an entry, that's fine
too, your decision.

[nikhil.sahni, 2017-04-13 08:56:56]

The CQ bit was checked by nikhil.sahni@samsung.com

[commit-bot: I haz the power, 2017-04-13 08:57:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 09:01:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 09:01:05]

Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[nikhil.sahni, 2017-04-13 10:26:10]

The CQ bit was checked by nikhil.sahni@samsung.com

[nikhil.sahni, 2017-04-13 10:26:11]

The patchset sent to the CQ was uploaded after l-g-t-m from foolip@chromium.org
Link to the patchset: https://codereview.chromium.org/2803603003/#ps40001
(title: "Rebase Patch")

[commit-bot: I haz the power, 2017-04-13 10:26:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 11:57:57]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492079170757130,
"parent_rev": "16904d20070be165ac263fa38155d6174c8839ca", "commit_rev":
"a5d70ebb214f8d77c943c98f1e2908c91b3d62b7"}

[commit-bot: I haz the power, 2017-04-13 11:58:52]

Description was changed from

==========
Removing support for document.createEvent("ProgressEvent")

BUG=703559
==========

to

==========
Removing support for document.createEvent("ProgressEvent")

BUG=703559

Review-Url: https://codereview.chromium.org/2803603003
Cr-Commit-Position: refs/heads/master@{#464378}
Committed:
https://chromium.googlesource.com/chromium/src/+/a5d70ebb214f8d77c943c98f1e29...
==========

[commit-bot: I haz the power, 2017-04-13 11:58:53]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a5d70ebb214f8d77c943c98f1e29...