Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2803593006: Disable test case ReceiveFramesFromFakeCaptureDevice/4 on Android (Closed)

Created:
3 years, 8 months ago by chfremer
Modified:
3 years, 8 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, chfremer+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable test case ReceiveFramesFromFakeCaptureDevice/4 on Android This test case was recently added [1] to exercise a code path for accelerated MJPEG decoding that is currently only in production use on Chromium OS and was previously not covered by any Chromium tests. This test case appears to fail intermittently on Android. This CL disables the test case for Android in order to mitigate the test flakiness it causes. [1] https://codereview.chromium.org/2772963002/ BUG=709039 TEST=content_browsertests --gtest_filter="VideoCaptureBrowserTest.*" Review-Url: https://codereview.chromium.org/2803593006 Cr-Commit-Position: refs/heads/master@{#462570} Committed: https://chromium.googlesource.com/chromium/src/+/600a408935228895ee63feb521044723f5fa23a2

Patch Set 1 #

Patch Set 2 : Put #if somewhere else, because Windows compilation failed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/browser/renderer_host/media/video_capture_browsertest.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
chfremer
PTAL
3 years, 8 months ago (2017-04-06 17:07:06 UTC) #3
Elly Fong-Jones
lgtm
3 years, 8 months ago (2017-04-06 17:07:51 UTC) #4
emircan
lgtm
3 years, 8 months ago (2017-04-06 17:12:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803593006/1
3 years, 8 months ago (2017-04-06 17:20:34 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/383614)
3 years, 8 months ago (2017-04-06 17:46:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803593006/20001
3 years, 8 months ago (2017-04-06 17:47:36 UTC) #12
chfremer
On 2017/04/06 17:46:08, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 8 months ago (2017-04-06 17:48:12 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 19:07:55 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/600a408935228895ee63feb52104...

Powered by Google App Engine
This is Rietveld 408576698