ui: Remove use of bitmaps when painting tab backgrounds.

chrome/browser/ui/views/tabs/tab.h

Index: chrome/browser/ui/views/tabs/tab.h
diff --git a/chrome/browser/ui/views/tabs/tab.h b/chrome/browser/ui/views/tabs/tab.h
index 7b7bc644e81e50785ca15f69330a514f3126bb59..0469d0f2856b62d260760f391204dd5f1d09bc5a 100644
--- a/chrome/browser/ui/views/tabs/tab.h
+++ b/chrome/browser/ui/views/tabs/tab.h
@@ -235,11 +235,19 @@ class Tab : public gfx::AnimationDelegate,
   // Paints a tab background using the image defined by |fill_id| at the
   // provided offset. If |fill_id| is 0, it will fall back to using the solid
   // color defined by the theme provider and ignore the offset.
-  void PaintTabBackgroundUsingFillId(gfx::Canvas* fill_canvas,
-                                     gfx::Canvas* stroke_canvas,
-                                     bool is_active,
-                                     int fill_id,
-                                     int y_offset);
+  void PaintTabBackground(gfx::Canvas* canvas,
+                          bool active,

[Peter Kasting, 2017/04/06 00:52:11]

Nit: For naming consistency, make this and the arg in PaintTabBackgroundStroke()
|is_active|.

[danakj, 2017/04/06 17:05:28]

I changed it because is_active is incorrect. This is "paint as if active". There
is one case where IsActive() is false, but we pass true to paint as active.

[Peter Kasting, 2017/04/06 18:49:45]

OK; can we name the arg to the fill function |active| then?

[danakj, 2017/04/06 20:08:52]

Yep, the .cc has it as |active| I just missed it here, will do.

+                          int fill_id,
+                          int y_offset,
+                          const gfx::Path* clip);
+  void PaintTabBackgroundFill(gfx::Canvas* canvas,

[Peter Kasting, 2017/04/06 00:52:11]

Nit: Maybe separate these two from the function above, with a comment like
"Helpers for PaintTabBackground() that paint the fill and stroke, respectively."

[danakj, 2017/04/06 17:05:28]

Done.

+                              const gfx::Path& fill_path,
+                              bool is_active,
+                              int fill_id,
+                              int y_offset);
+  void PaintTabBackgroundStroke(gfx::Canvas* canvas,
+                                const gfx::Path& fill_path,
+                                bool active);
 
   // Paints the pinned tab title changed indicator and |favicon_|. |favicon_|
   // may be null. |favicon_draw_bounds| is |favicon_bounds_| adjusted for rtl