ui: Remove use of bitmaps when painting tab backgrounds.

chrome/browser/ui/views/tabs/tab.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_TABS_TAB_H_
 #define CHROME_BROWSER_UI_VIEWS_TABS_TAB_H_
 
 #include <list>
 #include <memory>
 #include <string>
@@ skipping 217 matching lines @@
   // Paints with the normal tab style.  If |clip| is non-empty, the tab border
   // should be clipped against it.
   void PaintTab(gfx::Canvas* canvas, const gfx::Path& clip);
 
   // Paints the background of an inactive tab.
   void PaintInactiveTabBackground(gfx::Canvas* canvas, const gfx::Path& clip);
 
   // Paints a tab background using the image defined by |fill_id| at the
   // provided offset. If |fill_id| is 0, it will fall back to using the solid
   // color defined by the theme provider and ignore the offset.
-  void PaintTabBackgroundUsingFillId(gfx::Canvas* fill_canvas,
-                                     gfx::Canvas* stroke_canvas,
-                                     bool is_active,
-                                     int fill_id,
-                                     int y_offset);
+  void PaintTabBackground(gfx::Canvas* canvas,
+                          bool active,

[Peter Kasting, 2017/04/06 00:52:11]

Nit: For naming consistency, make this and the arg in PaintTabBackgroundStroke()
|is_active|.

[danakj, 2017/04/06 17:05:28]

I changed it because is_active is incorrect. This is "paint as if active". There
is one case where IsActive() is false, but we pass true to paint as active.

[Peter Kasting, 2017/04/06 18:49:45]

OK; can we name the arg to the fill function |active| then?

[danakj, 2017/04/06 20:08:52]

Yep, the .cc has it as |active| I just missed it here, will do.

+                          int fill_id,
+                          int y_offset,
+                          const gfx::Path* clip);
+  void PaintTabBackgroundFill(gfx::Canvas* canvas,

[Peter Kasting, 2017/04/06 00:52:11]

Nit: Maybe separate these two from the function above, with a comment like
"Helpers for PaintTabBackground() that paint the fill and stroke, respectively."

[danakj, 2017/04/06 17:05:28]

Done.

+                              const gfx::Path& fill_path,
+                              bool is_active,
+                              int fill_id,
+                              int y_offset);
+  void PaintTabBackgroundStroke(gfx::Canvas* canvas,
+                                const gfx::Path& fill_path,
+                                bool active);
 
   // Paints the pinned tab title changed indicator and |favicon_|. |favicon_|
   // may be null. |favicon_draw_bounds| is |favicon_bounds_| adjusted for rtl
   // and clipped to the bounds of the tab.
   void PaintPinnedTabTitleChangedIndicatorAndIcon(
       gfx::Canvas* canvas,
       const gfx::Rect& favicon_draw_bounds);
 
   // Paints the favicon, mirrored for RTL if needed.
   void PaintIcon(gfx::Canvas* canvas);
@@ skipping 99 matching lines @@
 
   // The favicon for the tab. This might be the sad tab icon or a copy of
   // data().favicon and may be modified for theming. It is created on demand
   // and thus may be null.
   gfx::ImageSkia favicon_;
 
   DISALLOW_COPY_AND_ASSIGN(Tab);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_TABS_TAB_H_