Avoid using language hint in encoding detection

Avoid using language hint in encoding detection

In general, avoid passing language hint to encoding detector.
This helps obtain more deterministic detection result regardless
of user system locale. Local file resources still benefit from
the hint, which is made an exception.

BUG=682978
Review-Url: https://codereview.chromium.org/2803563004
Cr-Commit-Position: refs/heads/master@{#462412}
Committed: https://chromium.googlesource.com/chromium/src/+/9e51d07999515ab5f8567ba8b446e316137eb0b8

[Jinsuk Kim, 2017-04-06 06:45:12]

The CQ bit was checked by jinsukkim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 06:47:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jinsuk Kim, 2017-04-06 07:21:59]

jinsukkim@chromium.org changed reviewers:
+ tkent@chromium.org

[tkent, 2017-04-06 07:29:13]

https://codereview.chromium.org/2803563004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/parser/TextResourceDecoder.cpp (right):

https://codereview.chromium.org/2803563004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/parser/TextResourceDecoder.cpp:168: if
(hintUrl.protocol() == "file" || !hintUrl.isEmpty()) {
The code is incorrect.  http:// URLs are not isEmpty(). So any URL passes this
condition.

BTW, I'd like to add file:// check to detectTextEncoding() rather than
TextResourceDecoder.  It would make unit testing easy.

[Jinsuk Kim, 2017-04-06 08:10:25]

https://codereview.chromium.org/2803563004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/parser/TextResourceDecoder.cpp (right):

https://codereview.chromium.org/2803563004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/parser/TextResourceDecoder.cpp:168: if
(hintUrl.protocol() == "file" || !hintUrl.isEmpty()) {
On 2017/04/06 07:29:13, tkent wrote:
> The code is incorrect.  http:// URLs are not isEmpty(). So any URL passes this
> condition.
> 
> BTW, I'd like to add file:// check to detectTextEncoding() rather than
> TextResourceDecoder.  It would make unit testing easy.

My bad.

Moved to TextEncodingDetector and updated tests.

[tkent, 2017-04-06 08:13:26]

lgtm

[Jinsuk Kim, 2017-04-06 08:14:38]

The CQ bit was checked by jinsukkim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 08:15:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 09:35:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 09:35:04]

Dry run: This issue passed the CQ dry run.

[Jinsuk Kim, 2017-04-06 10:12:27]

The CQ bit was checked by jinsukkim@chromium.org

[commit-bot: I haz the power, 2017-04-06 10:12:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 10:17:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491473547213850,
"parent_rev": "4a85cc3a3dd57a9811b794878a0056a27cbb058d", "commit_rev":
"9e51d07999515ab5f8567ba8b446e316137eb0b8"}

[commit-bot: I haz the power, 2017-04-06 10:17:55]

Description was changed from

==========
Avoid using language hint in encoding detection

In general, avoid passing language hint to encoding detector.
This helps obtain more deterministic detection result regardless
of user system locale. Local file resources still benefit from
the hint, which is made an exception.

BUG=682978
==========

to

==========
Avoid using language hint in encoding detection

In general, avoid passing language hint to encoding detector.
This helps obtain more deterministic detection result regardless
of user system locale. Local file resources still benefit from
the hint, which is made an exception.

BUG=682978

Review-Url: https://codereview.chromium.org/2803563004
Cr-Commit-Position: refs/heads/master@{#462412}
Committed:
https://chromium.googlesource.com/chromium/src/+/9e51d07999515ab5f8567ba8b446...
==========

[commit-bot: I haz the power, 2017-04-06 10:17:56]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9e51d07999515ab5f8567ba8b446...