Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 2803543005: [Payments] iOS: Support basic-card (Closed)

Created:
3 years, 8 months ago by Mathieu
Modified:
3 years, 8 months ago
Reviewers:
Moe
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, mahmadi+paymentsioswatch_chromium.org, pkl (ping after 24h if needed), gogerald+paymentswatch_chromium.org, rouslan+payments_chromium.org, marq+watch_chromium.org, noyau+watch_chromium.org, mahmadi+paymentswatch_chromium.org, sebsg+paymentswatch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payments] iOS: Support basic-card Will now parse the basic-card payment method and return that as the |method_name| if appropriate. BUG=708052 TEST=ios_chrome_unittests Review-Url: https://codereview.chromium.org/2803543005 Cr-Commit-Position: refs/heads/master@{#462625} Committed: https://chromium.googlesource.com/chromium/src/+/300ed63a3d3f33a6ddcf3d1d9fa49b2582e36cbd

Patch Set 1 #

Total comments: 8

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -12 lines) Patch
M ios/chrome/browser/payments/payment_request.h View 3 chunks +11 lines, -1 line 0 comments Download
M ios/chrome/browser/payments/payment_request.mm View 1 2 chunks +7 lines, -9 lines 0 comments Download
M ios/chrome/browser/payments/payment_request_coordinator.mm View 1 1 chunk +10 lines, -2 lines 0 comments Download
M ios/chrome/browser/payments/payment_request_unittest.mm View 1 1 chunk +139 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Mathieu
Moe PTAL!
3 years, 8 months ago (2017-04-06 18:31:50 UTC) #4
Moe
On 2017/04/06 18:31:50, Mathieu wrote: > Moe PTAL! LGTM % nits and comments. Amazing work ...
3 years, 8 months ago (2017-04-06 20:50:56 UTC) #8
Moe
https://codereview.chromium.org/2803543005/diff/1/ios/chrome/browser/payments/payment_request.mm File ios/chrome/browser/payments/payment_request.mm (right): https://codereview.chromium.org/2803543005/diff/1/ios/chrome/browser/payments/payment_request.mm#newcode99 ios/chrome/browser/payments/payment_request.mm:99: // TODO(crbug.com/602666): Update the following logic to allow basic ...
3 years, 8 months ago (2017-04-06 20:51:03 UTC) #9
Mathieu
Thankss, submitting https://codereview.chromium.org/2803543005/diff/1/ios/chrome/browser/payments/payment_request.mm File ios/chrome/browser/payments/payment_request.mm (right): https://codereview.chromium.org/2803543005/diff/1/ios/chrome/browser/payments/payment_request.mm#newcode99 ios/chrome/browser/payments/payment_request.mm:99: // TODO(crbug.com/602666): Update the following logic to ...
3 years, 8 months ago (2017-04-06 21:04:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803543005/20001
3 years, 8 months ago (2017-04-06 21:05:39 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 21:23:08 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/300ed63a3d3f33a6ddcf3d1d9fa4...

Powered by Google App Engine
This is Rietveld 408576698