[Payments] iOS: Support basic-card

[Payments] iOS: Support basic-card

Will now parse the basic-card payment method and return that as the
|method_name| if appropriate.

BUG=708052
TEST=ios_chrome_unittests

Review-Url: https://codereview.chromium.org/2803543005
Cr-Commit-Position: refs/heads/master@{#462625}
Committed: https://chromium.googlesource.com/chromium/src/+/300ed63a3d3f33a6ddcf3d1d9fa49b2582e36cbd

[Mathieu, 2017-04-06 18:31:43]

Description was changed from

==========
[Payments] iOS: Support basic-card

Will now parse the basic-card payment method and return that as the
|method_name| if appropriate.

BUG=708052
TEST=ios_chrome_unittests
==========

to

==========
[Payments] iOS: Support basic-card

Will now parse the basic-card payment method and return that as the
|method_name| if appropriate.

BUG=708052
TEST=ios_chrome_unittests
==========

[Mathieu, 2017-04-06 18:31:43]

mathp@chromium.org changed reviewers:
+ mahmadi@chromium.org

[Mathieu, 2017-04-06 18:31:48]

The CQ bit was checked by mathp@chromium.org to run a CQ dry run

[Mathieu, 2017-04-06 18:31:50]

Moe PTAL!

[commit-bot: I haz the power, 2017-04-06 18:33:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 18:49:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 18:49:08]

Dry run: This issue passed the CQ dry run.

[Moe, 2017-04-06 20:50:56]

On 2017/04/06 18:31:50, Mathieu wrote:
> Moe PTAL!

LGTM % nits and comments. Amazing work Mathieu! Thank you!

[Moe, 2017-04-06 20:51:03]

https://codereview.chromium.org/2803543005/diff/1/ios/chrome/browser/payments...
File ios/chrome/browser/payments/payment_request.mm (right):

https://codereview.chromium.org/2803543005/diff/1/ios/chrome/browser/payments...
ios/chrome/browser/payments/payment_request.mm:99: // TODO(crbug.com/602666):
Update the following logic to allow basic card
Could you please remove this comment now that we do support basic cards?

https://codereview.chromium.org/2803543005/diff/1/ios/chrome/browser/payments...
File ios/chrome/browser/payments/payment_request_coordinator.mm (right):

https://codereview.chromium.org/2803543005/diff/1/ios/chrome/browser/payments...
ios/chrome/browser/payments/payment_request_coordinator.mm:218:
_paymentRequest->basic_card_specified_networks().count(basic_card_type)
nit: find() demonstrates the intent more clearly.

https://codereview.chromium.org/2803543005/diff/1/ios/chrome/browser/payments...
File ios/chrome/browser/payments/payment_request_unittest.mm (right):

https://codereview.chromium.org/2803543005/diff/1/ios/chrome/browser/payments...
ios/chrome/browser/payments/payment_request_unittest.mm:111: // soon as one
entry doesn't specify anything in supported_methods.
Should we combine this test with the previous one?  It seems like we're testing
whether empty values are ignored or not.

https://codereview.chromium.org/2803543005/diff/1/ios/chrome/browser/payments...
ios/chrome/browser/payments/payment_request_unittest.mm:207: // some methods
what is this testing?

[Mathieu, 2017-04-06 21:04:41]

Thankss, submitting

https://codereview.chromium.org/2803543005/diff/1/ios/chrome/browser/payments...
File ios/chrome/browser/payments/payment_request.mm (right):

https://codereview.chromium.org/2803543005/diff/1/ios/chrome/browser/payments...
ios/chrome/browser/payments/payment_request.mm:99: // TODO(crbug.com/602666):
Update the following logic to allow basic card
On 2017/04/06 20:51:03, moe wrote:
> Could you please remove this comment now that we do support basic cards?

haha. good catch.

https://codereview.chromium.org/2803543005/diff/1/ios/chrome/browser/payments...
File ios/chrome/browser/payments/payment_request_coordinator.mm (right):

https://codereview.chromium.org/2803543005/diff/1/ios/chrome/browser/payments...
ios/chrome/browser/payments/payment_request_coordinator.mm:218:
_paymentRequest->basic_card_specified_networks().count(basic_card_type)
On 2017/04/06 20:51:03, moe wrote:
> nit: find() demonstrates the intent more clearly.

Done.

https://codereview.chromium.org/2803543005/diff/1/ios/chrome/browser/payments...
File ios/chrome/browser/payments/payment_request_unittest.mm (right):

https://codereview.chromium.org/2803543005/diff/1/ios/chrome/browser/payments...
ios/chrome/browser/payments/payment_request_unittest.mm:111: // soon as one
entry doesn't specify anything in supported_methods.
On 2017/04/06 20:51:03, moe wrote:
> Should we combine this test with the previous one?  It seems like we're
testing
> whether empty values are ignored or not.

Good point

https://codereview.chromium.org/2803543005/diff/1/ios/chrome/browser/payments...
ios/chrome/browser/payments/payment_request_unittest.mm:207: // some methods
On 2017/04/06 20:51:03, moe wrote:
> what is this testing?

Specifying basic-card with supported networks. It's embedded in other tests, but
in case those change, this one is a pretty simple case.

[Mathieu, 2017-04-06 21:04:49]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2017-04-06 21:04:49]

The patchset sent to the CQ was uploaded after l-g-t-m from mahmadi@chromium.org
Link to the patchset: https://codereview.chromium.org/2803543005/#ps20001
(title: "addressed comments")

[commit-bot: I haz the power, 2017-04-06 21:05:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 21:21:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491512689412100,
"parent_rev": "7e49f5ac85d0ac4d401349f39f07987475308e36", "commit_rev":
"300ed63a3d3f33a6ddcf3d1d9fa49b2582e36cbd"}

[commit-bot: I haz the power, 2017-04-06 21:23:07]

Description was changed from

==========
[Payments] iOS: Support basic-card

Will now parse the basic-card payment method and return that as the
|method_name| if appropriate.

BUG=708052
TEST=ios_chrome_unittests
==========

to

==========
[Payments] iOS: Support basic-card

Will now parse the basic-card payment method and return that as the
|method_name| if appropriate.

BUG=708052
TEST=ios_chrome_unittests

Review-Url: https://codereview.chromium.org/2803543005
Cr-Commit-Position: refs/heads/master@{#462625}
Committed:
https://chromium.googlesource.com/chromium/src/+/300ed63a3d3f33a6ddcf3d1d9fa4...
==========

[commit-bot: I haz the power, 2017-04-06 21:23:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/300ed63a3d3f33a6ddcf3d1d9fa4...