Always create ClientNativePixmapFactory in chrome --mash

Always create ClientNativePixmapFactory in chrome --mash

With the enabling of the --enable-native-gpu-memory-buffers on
selected ChromeOS devices where the combination of kernel and graphics
hardware permit it, every Chrome process attempting to rastersize
requires an ozone gfx::ClientNativePixmapFactory instance or it will
crash when first attempting to allocate a graphics buffer.

Given that aura is the standard mus client library for non-renderer processes
and is assumed by all ozone platforms, modify aura::Env to create such an
instance and resolve the situation where chrome --mash fails on selected
ChromeOS devices.

BUG=704169
Review-Url: https://codereview.chromium.org/2803523002
Cr-Commit-Position: refs/heads/master@{#464666}
Committed: https://chromium.googlesource.com/chromium/src/+/74d8cb5db7109d9f5426136662b6dd614494c545

[rjkroege, 2017-04-05 00:33:38]

rjkroege@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2017-04-05 03:13:02]

Is there a better way to do this only if the process is going to render to the
screen? Also, putting this here means running mash from the command line (not
through mash_runner) won't work, right? Would it make sense to make MusClient or
WindowTreeClient do the registration you have?

[rjkroege, 2017-04-07 21:21:24]

Description was changed from

==========
Always create ClientNativePixmapFactory in chrome --mash

With the enabling of the --enable-native-gpu-memory-buffers on
selected ChromeOS devices where the combination of kernel and graphics
hardware permit it, every Chrome process attempting to rastersize
requires an ozone gfx::ClientNativePixmapFactory instance or it will
crash when first attempting to allocate a graphics buffer.

Modify MashRunner to create such an instance in all cases and thereby
resolve the situation where chrome --mash fails on selected ChromeOS
devices.

BUG=704169
==========

to

==========
Always create ClientNativePixmapFactory in chrome --mash

With the enabling of the --enable-native-gpu-memory-buffers on
selected ChromeOS devices where the combination of kernel and graphics
hardware permit it, every Chrome process attempting to rastersize
requires an ozone gfx::ClientNativePixmapFactory instance or it will
crash when first attempting to allocate a graphics buffer.

Given that aura is the standard mus client library for non-renderer processes
and is assumed by all ozone platforms, modify aura::Env to create such an
instance and resolve the situation where chrome --mash fails on selected
ChromeOS devices.

BUG=704169
==========

[rjkroege, 2017-04-07 21:22:39]

rjkroege@chromium.org changed reviewers:
+ piman@chromium.org

[rjkroege, 2017-04-07 21:22:39]

ptal

piman@ OWNERS review for content/browser/browser_main_loop.cc

[piman, 2017-04-07 22:26:02]

lgtm

[sky, 2017-04-07 23:23:20]

https://codereview.chromium.org/2803523002/diff/20001/ui/aura/env.cc
File ui/aura/env.cc (right):

https://codereview.chromium.org/2803523002/diff/20001/ui/aura/env.cc#newcode202
ui/aura/env.cc:202: void Env::Init() {
Be aware that some tests reset the mode after the fact. This is generally only
for going from local to mus.

https://codereview.chromium.org/2803523002/diff/20001/ui/aura/env.cc#newcode217
ui/aura/env.cc:217:
gfx::ClientNativePixmapFactory::SetInstance(native_pixmap_factory_.get());
SetInstance(null) in the destructor?

[rjkroege, 2017-04-10 16:21:42]

ptal

https://codereview.chromium.org/2803523002/diff/20001/ui/aura/env.cc
File ui/aura/env.cc (right):

https://codereview.chromium.org/2803523002/diff/20001/ui/aura/env.cc#newcode202
ui/aura/env.cc:202: void Env::Init() {
On 2017/04/07 23:23:19, sky wrote:
> Be aware that some tests reset the mode after the fact. This is generally only
> for going from local to mus.

I don't understand what you mean. They do this by destructing the aura::Env
instance?

https://codereview.chromium.org/2803523002/diff/20001/ui/aura/env.cc#newcode217
ui/aura/env.cc:217:
gfx::ClientNativePixmapFactory::SetInstance(native_pixmap_factory_.get());
On 2017/04/07 23:23:20, sky wrote:
> SetInstance(null) in the destructor?

Done.

[sky, 2017-04-10 16:23:24]

LGTM

[rjkroege, 2017-04-10 16:23:32]

The CQ bit was checked by rjkroege@chromium.org

[rjkroege, 2017-04-10 16:23:33]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2803523002/#ps40001
(title: "review comments")

[commit-bot: I haz the power, 2017-04-10 16:24:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 16:53:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 16:53:02]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[rjkroege, 2017-04-13 01:01:09]

The CQ bit was checked by rjkroege@chromium.org

[rjkroege, 2017-04-13 01:01:09]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2803523002/#ps60001
(title: "fix DCHECK oversight")

[commit-bot: I haz the power, 2017-04-13 01:02:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 02:57:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-13 02:57:35]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rjkroege, 2017-04-14 01:21:16]

The CQ bit was checked by rjkroege@chromium.org

[rjkroege, 2017-04-14 01:21:16]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2803523002/#ps80001
(title: "rebased")

[commit-bot: I haz the power, 2017-04-14 01:21:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-14 03:17:22]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1492132876273790,
"parent_rev": "e2b8278dd5aaf5a6ec415aa5e7dd828f17b644f6", "commit_rev":
"74d8cb5db7109d9f5426136662b6dd614494c545"}

[commit-bot: I haz the power, 2017-04-14 03:18:54]

Description was changed from

==========
Always create ClientNativePixmapFactory in chrome --mash

With the enabling of the --enable-native-gpu-memory-buffers on
selected ChromeOS devices where the combination of kernel and graphics
hardware permit it, every Chrome process attempting to rastersize
requires an ozone gfx::ClientNativePixmapFactory instance or it will
crash when first attempting to allocate a graphics buffer.

Given that aura is the standard mus client library for non-renderer processes
and is assumed by all ozone platforms, modify aura::Env to create such an
instance and resolve the situation where chrome --mash fails on selected
ChromeOS devices.

BUG=704169
==========

to

==========
Always create ClientNativePixmapFactory in chrome --mash

With the enabling of the --enable-native-gpu-memory-buffers on
selected ChromeOS devices where the combination of kernel and graphics
hardware permit it, every Chrome process attempting to rastersize
requires an ozone gfx::ClientNativePixmapFactory instance or it will
crash when first attempting to allocate a graphics buffer.

Given that aura is the standard mus client library for non-renderer processes
and is assumed by all ozone platforms, modify aura::Env to create such an
instance and resolve the situation where chrome --mash fails on selected
ChromeOS devices.

BUG=704169

Review-Url: https://codereview.chromium.org/2803523002
Cr-Commit-Position: refs/heads/master@{#464666}
Committed:
https://chromium.googlesource.com/chromium/src/+/74d8cb5db7109d9f5426136662b6...
==========

[commit-bot: I haz the power, 2017-04-14 03:18:55]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/74d8cb5db7109d9f5426136662b6...