Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2803513003: Remove ParsedCertificate::unparsed_extensions(). (Closed)

Created:
3 years, 8 months ago by eroman
Modified:
3 years, 8 months ago
Reviewers:
dougsteed, mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org, dougsteed+watch_chromium.org, mac-reviews_chromium.org, ryanchung+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ParsedCertificate::unparsed_extensions(). This was an awkard abstraction that better belongs in the verification code. In the process, also added Extended Key Usage and Policies into ParsedCertificate. BUG=634442 Review-Url: https://codereview.chromium.org/2803513003 Cr-Commit-Position: refs/heads/master@{#462240} Committed: https://chromium.googlesource.com/chromium/src/+/ab15aa6c043139c2f88bda31d8003823c9d16004

Patch Set 1 #

Patch Set 2 : checkpoint #

Patch Set 3 : remove unused #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -114 lines) Patch
M components/cast_certificate/cast_cert_validator.cc View 1 2 2 chunks +4 lines, -30 lines 0 comments Download
M net/cert/cert_verify_proc_mac.cc View 1 2 chunks +4 lines, -31 lines 0 comments Download
M net/cert/internal/parsed_certificate.h View 1 4 chunks +36 lines, -5 lines 0 comments Download
M net/cert/internal/parsed_certificate.cc View 6 chunks +42 lines, -20 lines 0 comments Download
M net/cert/internal/parsed_certificate_unittest.cc View 5 chunks +29 lines, -24 lines 0 comments Download
M net/cert/internal/verify_certificate_chain.cc View 1 1 chunk +21 lines, -4 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
eroman
3 years, 8 months ago (2017-04-05 01:14:41 UTC) #5
dougsteed
lgtm
3 years, 8 months ago (2017-04-05 15:45:23 UTC) #12
mattm
lgtm!
3 years, 8 months ago (2017-04-05 21:28:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803513003/40001
3 years, 8 months ago (2017-04-05 22:03:44 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 22:12:13 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ab15aa6c043139c2f88bda31d800...

Powered by Google App Engine
This is Rietveld 408576698