Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2803463003:
[Sync] Use un-expired time for testing (Closed)
|
Created:
3 years, 8 months ago by Gang Wu Modified:
3 years, 8 months ago CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, baxley+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, huangml+watch_chromium.org, liaoyuke+watch_chromium.org, sdefresne+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[Sync] Use un-expired time for testing
Don't use expired time since sync will filter out expired time, so use
Time::Now() instead.
BUG=707846
Review-Url: https://codereview.chromium.org/2803463003
Cr-Commit-Position: refs/heads/master@{#462127}
Committed: https://chromium.googlesource.com/chromium/src/+/351ea8942e01f28a8f00359d772a4444e56f0de0
Patch Set 1 #Patch Set 2 : remove fix to check if the tests fail #Patch Set 3 : add fix back #
Messages
Total messages: 29 (24 generated)
The CQ bit was checked by gangwu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by gangwu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by gangwu@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== fix tests BUG= ========== to ========== fix tests BUG= ==========
gangwu@chromium.org changed reviewers: + msarda@chromium.org
Description was changed from ========== fix tests BUG= ========== to ========== [Sync] Use un-expired time for testing Don't use expired time since sync will filter out expired time, so use Time::Now() instead. BUG=707846 ==========
gangwu@chromium.org changed reviewers: + baxley@chromium.org
gangwu@chromium.org changed reviewers: + rohitrao@chromium.org - baxley@chromium.org, msarda@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
gangwu@chromium.org changed reviewers: + baxley@chromium.org, msarda@chromium.org - rohitrao@chromium.org
PTAL
gangwu@chromium.org changed reviewers: + rohitrao@chromium.org
On 2017/04/05 04:34:42, Gang Wu wrote: > PTAL I think the CL description should have a linebreak after the first line, and the second line of text should be <=72 chars. Thanks for the fix! LGTM (I only have OWNERS for ios/chrome/test/)
lgtm, thanks for fixing!
Description was changed from ========== [Sync] Use un-expired time for testing Don't use expired time since sync will filter out expired time, so use Time::Now() instead. BUG=707846 ========== to ========== [Sync] Use un-expired time for testing Don't use expired time since sync will filter out expired time, so use Time::Now() instead. BUG=707846 ==========
Description was changed from ========== [Sync] Use un-expired time for testing Don't use expired time since sync will filter out expired time, so use Time::Now() instead. BUG=707846 ========== to ========== [Sync] Use un-expired time for testing Don't use expired time since sync will filter out expired time, so use Time::Now() instead. BUG=707846 ==========
The CQ bit was checked by gangwu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491412151109520,
"parent_rev": "9984162f48e7ad8c34454f35d5e9a076cbdfe573", "commit_rev":
"351ea8942e01f28a8f00359d772a4444e56f0de0"}
Message was sent while issue was closed.
Description was changed from ========== [Sync] Use un-expired time for testing Don't use expired time since sync will filter out expired time, so use Time::Now() instead. BUG=707846 ========== to ========== [Sync] Use un-expired time for testing Don't use expired time since sync will filter out expired time, so use Time::Now() instead. BUG=707846 Review-Url: https://codereview.chromium.org/2803463003 Cr-Commit-Position: refs/heads/master@{#462127} Committed: https://chromium.googlesource.com/chromium/src/+/351ea8942e01f28a8f00359d772a... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/351ea8942e01f28a8f00359d772a... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
