Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 2803443002: Revert of [cronet] Expose API to set experimental options (Closed)

Created:
3 years, 8 months ago by lilyhoughton
Modified:
3 years, 8 months ago
Reviewers:
lilyhoughton1, mef, xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [cronet] Expose API to set experimental options (patchset #3 id:40001 of https://codereview.chromium.org/2760073002/ ) Reason for revert: seems to break ios-simulator trybot Original issue's description: > [cronet] Expose API to set experimental options > > Add CPP function CronetEnvironment::set_experimental_options(std::string) > and Obj-C function [Cronet setExperimentalOption:(NSString*)]. > > BUG=702789 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester > > Review-Url: https://codereview.chromium.org/2760073002 > Cr-Commit-Position: refs/heads/master@{#461511} > Committed: https://chromium.googlesource.com/chromium/src/+/afb25842158a4bad4c7e61dfc0b1c48223f9d351 TBR=mef@chromium.org,xunjieli@chromium.org,lilyhoughton@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=702789 Review-Url: https://codereview.chromium.org/2803443002 Cr-Commit-Position: refs/heads/master@{#462066} Committed: https://chromium.googlesource.com/chromium/src/+/5e10e328115fa52a2fd8a749642d4598b8b7cb9d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -36 lines) Patch
M components/cronet/ios/Cronet.h View 1 chunk +0 lines, -5 lines 0 comments Download
M components/cronet/ios/Cronet.mm View 4 chunks +1 line, -9 lines 0 comments Download
M components/cronet/ios/cronet_environment.h View 2 chunks +0 lines, -5 lines 0 comments Download
M components/cronet/ios/cronet_environment.mm View 2 chunks +6 lines, -5 lines 0 comments Download
M components/cronet/ios/test/cronet_http_test.mm View 1 chunk +0 lines, -11 lines 0 comments Download
M components/cronet/ios/test/start_cronet.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
lilyhoughton
Created Revert of [cronet] Expose API to set experimental options
3 years, 8 months ago (2017-04-04 20:20:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803443002/1
3 years, 8 months ago (2017-04-04 20:21:26 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-04 20:21:28 UTC) #5
xunjieli
lgtm
3 years, 8 months ago (2017-04-04 20:27:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803443002/1
3 years, 8 months ago (2017-04-05 14:31:05 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 14:41:27 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5e10e328115fa52a2fd8a749642d...

Powered by Google App Engine
This is Rietveld 408576698