Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2803413002: DevTools: brush up paint marker rendering, sort experiments, restore event markers on the overview. (Closed)

Created:
3 years, 8 months ago by pfeldman
Modified:
3 years, 8 months ago
Reviewers:
caseq
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: brush up paint marker rendering, sort experiments, restore event markers on the overview. Review-Url: https://codereview.chromium.org/2803413002 Cr-Commit-Position: refs/heads/master@{#464256} Committed: https://chromium.googlesource.com/chromium/src/+/770351d1a6f67f9c9523de9b84552a14ec8b7eec

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebaselined #

Patch Set 3 : rebaselined #

Patch Set 4 : fixed the test #

Messages

Total messages: 24 (14 generated)
pfeldman
3 years, 8 months ago (2017-04-07 23:59:24 UTC) #2
caseq
lgtm https://codereview.chromium.org/2803413002/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js (right): https://codereview.chromium.org/2803413002/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js#newcode1721 third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js:1721: color = 'orange'; Let's use other color. This ...
3 years, 8 months ago (2017-04-08 01:04:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803413002/1
3 years, 8 months ago (2017-04-10 18:33:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/187595) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 8 months ago (2017-04-10 18:37:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803413002/20001
3 years, 8 months ago (2017-04-11 00:18:38 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/344335) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 8 months ago (2017-04-11 00:22:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803413002/40001
3 years, 8 months ago (2017-04-11 21:38:26 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/420035)
3 years, 8 months ago (2017-04-11 23:17:38 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803413002/60001
3 years, 8 months ago (2017-04-12 22:11:54 UTC) #20
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 02:45:32 UTC) #24
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/770351d1a6f67f9c9523de9b8455...

Powered by Google App Engine
This is Rietveld 408576698