Rename caretDisplayItemClient() to getCaretDisplayItemClient().

Rename caretDisplayItemClient() to getCaretDisplayItemClient().

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a
|CaretDisplayItemClient| type and a |caretDisplayItemClient| accessor
method in the CaretDisplayItemClientTest class (differing by case of the
first character); after a naive rename by the rewrite_to_chrome_style
tool we would end up with |CaretDisplayItemClient| being the name of
both the type and the accessor method (with both living in the same
namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312
TBR=yosin@chromium.org

Review-Url: https://codereview.chromium.org/2803363002
Cr-Commit-Position: refs/heads/master@{#463051}
Committed: https://chromium.googlesource.com/chromium/src/+/00daa6ffb9302d37c20324ab4f36485969b63a5a

[Łukasz Anforowicz, 2017-04-07 21:59:52]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 22:00:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2017-04-07 22:00:24]

yosin@, FYI - I plan to TBR this CL, because:

1. It is quite a safe, mechanical rename of a method (and it follows the pattern
of other already landed CLs for https://crbug.com/582312)

2. We are trying to flush out all the known issues before trying to perform the
Great Blink Rename this coming weekend (and I hope to land this CL soon, to
squeeze in one more dry-run on before Saturday).

[Łukasz Anforowicz, 2017-04-07 22:13:59]

The CQ bit was unchecked by lukasza@chromium.org

[Łukasz Anforowicz, 2017-04-07 22:14:02]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2017-04-07 22:14:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2017-04-07 22:17:52]

dcheng@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2017-04-07 22:17:52]

lgtm

[commit-bot: I haz the power, 2017-04-07 23:39:27]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491603242600220, "parent_rev":
"ae910dd7ccf483d4c3b57cefafda32f36baf7ab9", "commit_rev":
"00daa6ffb9302d37c20324ab4f36485969b63a5a"}

[commit-bot: I haz the power, 2017-04-07 23:40:19]

Description was changed from

==========
Rename caretDisplayItemClient() to getCaretDisplayItemClient().

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a
|CaretDisplayItemClient| type and a |caretDisplayItemClient| accessor
method in the CaretDisplayItemClientTest class (differing by case of the
first character); after a naive rename by the rewrite_to_chrome_style
tool we would end up with |CaretDisplayItemClient| being the name of
both the type and the accessor method (with both living in the same
namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312
TBR=yosin@chromium.org
==========

to

==========
Rename caretDisplayItemClient() to getCaretDisplayItemClient().

The rename is needed to avoid a naming collision after changing from
Blink to Chromium naming style.  Right now we have a
|CaretDisplayItemClient| type and a |caretDisplayItemClient| accessor
method in the CaretDisplayItemClientTest class (differing by case of the
first character); after a naive rename by the rewrite_to_chrome_style
tool we would end up with |CaretDisplayItemClient| being the name of
both the type and the accessor method (with both living in the same
namespace).

Prepending a "get" prefix to the name of the accessor method is the
workaround that fits into the guidance on the recommended
post-Blink-to-Chromium-rename style suggested by esprehn@ in
https://crbug.com/582312#c17:
- Getters favor not using "Get", ex. FirstChild()
- Unless the type name conflicts, in which case you can either rename
  the type if it's easy and makes sense, or add "Get", ex. GetContext().

BUG=582312
TBR=yosin@chromium.org

Review-Url: https://codereview.chromium.org/2803363002
Cr-Commit-Position: refs/heads/master@{#463051}
Committed:
https://chromium.googlesource.com/chromium/src/+/00daa6ffb9302d37c20324ab4f36...
==========

[commit-bot: I haz the power, 2017-04-07 23:40:19]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/00daa6ffb9302d37c20324ab4f36...