Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 2803353002: Change dest_language to target_language in the logistic regression model for consistency with googl… (Closed)

Created:
3 years, 8 months ago by hamelphi
Modified:
3 years, 8 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, Roger McFarlane (Chromium)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change dest_language to target_language in the logistic regression model for consistency with google3 proto and translate_event_protos. BUG=646711 Review-Url: https://codereview.chromium.org/2803353002 Cr-Commit-Position: refs/heads/master@{#463410} Committed: https://chromium.googlesource.com/chromium/src/+/28f186338efaf147e981787624c2ca223b6efe40

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M components/translate/core/browser/proto/translate_ranker_model.proto View 1 chunk +1 line, -1 line 0 comments Download
M components/translate/core/browser/translate_ranker_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/translate/core/browser/translate_ranker_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
hamelphi
3 years, 8 months ago (2017-04-07 21:40:49 UTC) #2
groby-ooo-7-16
RS LGTM
3 years, 8 months ago (2017-04-10 20:54:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803353002/1
3 years, 8 months ago (2017-04-10 20:57:44 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 21:54:58 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/28f186338efaf147e981787624c2...

Powered by Google App Engine
This is Rietveld 408576698