Avoiding name collisions between flexbox and grid

Avoiding name collisions between flexbox and grid

I'm still experimenting with unity builds and one of the name
collisions that you encounter when compiling layout is between flexbox
code and grid code. This patch changes top level functions to be
member functions.

No functional changes.

Review-Url: https://codereview.chromium.org/2803323002
Cr-Commit-Position: refs/heads/master@{#463059}
Committed: https://chromium.googlesource.com/chromium/src/+/5392421cd9ab433cde8db096921257121f7ef20b

[Daniel Bratell, 2017-04-07 19:06:14]

bratell@opera.com changed reviewers:
+ cbiesinger@chromium.org, svillar@igalia.com

[Daniel Bratell, 2017-04-07 19:06:14]

Please take a look!

[Daniel Bratell, 2017-04-07 19:11:40]

The CQ bit was checked by bratell@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 19:12:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 19:25:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 19:25:38]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Daniel Bratell, 2017-04-07 19:31:04]

The CQ bit was checked by bratell@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 19:31:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 20:54:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 20:54:20]

Dry run: This issue passed the CQ dry run.

[cbiesinger, 2017-04-07 21:26:28]

lgtm for flexbox with comment below. Please wait for review from
svillar/rego/jfernandez for the grid change.

https://codereview.chromium.org/2803323002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h (right):

https://codereview.chromium.org/2803323002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h:238: static const
StyleContentAlignmentData& contentAlignmentNormalBehavior();
Please try to sort the functions in the header file the same as in the .cpp
file. In this case, please put these declarations before firstLineBoxBaseline in
the header.

[jfernandez, 2017-04-07 21:33:48]

jfernandez@igalia.com changed reviewers:
+ jfernandez@igalia.com

[jfernandez, 2017-04-07 21:33:48]

lgtm

lgtm for the grid layout changes.

[Daniel Bratell, 2017-04-07 21:54:51]

https://codereview.chromium.org/2803323002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h (right):

https://codereview.chromium.org/2803323002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h:238: static const
StyleContentAlignmentData& contentAlignmentNormalBehavior();
On 2017/04/07 21:26:28, cbiesinger wrote:
> Please try to sort the functions in the header file the same as in the .cpp
> file. In this case, please put these declarations before firstLineBoxBaseline
in
> the header.

Done.

[Daniel Bratell, 2017-04-07 21:55:15]

The CQ bit was checked by bratell@opera.com

[Daniel Bratell, 2017-04-07 21:55:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbiesinger@chromium.org, jfernandez@igalia.com
Link to the patchset: https://codereview.chromium.org/2803323002/#ps40001
(title: "Moved functions around.")

[commit-bot: I haz the power, 2017-04-07 21:55:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 23:57:35]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491602115978210,
"parent_rev": "c05e448588744f4d75142587d7b3b1d8ecf3a87f", "commit_rev":
"5392421cd9ab433cde8db096921257121f7ef20b"}

[commit-bot: I haz the power, 2017-04-07 23:58:26]

Description was changed from

==========
Avoiding name collisions between flexbox and grid

I'm still experimenting with unity builds and one of the name
collisions that you encounter when compiling layout is between flexbox
code and grid code. This patch changes top level functions to be
member functions.

No functional changes.
==========

to

==========
Avoiding name collisions between flexbox and grid

I'm still experimenting with unity builds and one of the name
collisions that you encounter when compiling layout is between flexbox
code and grid code. This patch changes top level functions to be
member functions.

No functional changes.

Review-Url: https://codereview.chromium.org/2803323002
Cr-Commit-Position: refs/heads/master@{#463059}
Committed:
https://chromium.googlesource.com/chromium/src/+/5392421cd9ab433cde8db0969212...
==========

[commit-bot: I haz the power, 2017-04-07 23:58:27]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5392421cd9ab433cde8db0969212...