Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h

Issue 2803293002: Create Bookmark Footnote desktop iOS promotion (Closed)
Patch Set: win only Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h
index 1bd77a8d50145fc3e42ef2115c5a0f3e3cfdfb3a..f9d510e85f2eeee6491a4a2e5850f1b0a0a00195 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h
@@ -12,6 +12,7 @@
#include "base/macros.h"
#include "base/strings/string16.h"
#include "chrome/browser/ui/bookmarks/recently_used_folders_combo_model.h"
+#include "chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion_footnote_delegate.h"
#include "chrome/browser/ui/sync/bubble_sync_promo_delegate.h"
#include "chrome/browser/ui/views/location_bar/location_bar_bubble_delegate_view.h"
#include "ui/views/controls/button/button.h"
@@ -26,6 +27,12 @@ namespace bookmarks {
class BookmarkBubbleObserver;
}
+#if defined(OS_WIN)
+namespace desktop_ios_promotion {
+enum class PromotionEntryPoint;
+}
+#endif
+
namespace views {
class LabelButton;
class Textfield;
@@ -37,7 +44,8 @@ class Textfield;
// instead use the static Show method.
class BookmarkBubbleView : public LocationBarBubbleDelegateView,
public views::ButtonListener,
- public views::ComboboxListener {
+ public views::ComboboxListener,
+ public DesktopIOSPromotionFootnoteDelegate {
public:
// If |anchor_view| is null, |anchor_rect| is used to anchor the bubble and
// |parent_window| is used to ensure the bubble closes if the parent closes.
@@ -111,9 +119,16 @@ class BookmarkBubbleView : public LocationBarBubbleDelegateView,
// Sets the title and parent of the node.
void ApplyEdits();
+ // DesktopIOSPromotionFootnoteDelegate :
+ void OnIOSPromotionFootnoteLinkClicked() override;
+
#if defined(OS_WIN)
+ // Check eligiblity to showthe iOS promotion from a specific entry point.
+ bool IsIOSPromotionEligible(
+ desktop_ios_promotion::PromotionEntryPoint entry_point);
+
// Shows the iOS promotion.
- void ShowIOSPromotion();
+ void ShowIOSPromotion(desktop_ios_promotion::PromotionEntryPoint entry_point);
#endif
// The bookmark bubble, if we're showing one.
@@ -159,6 +174,9 @@ class BookmarkBubbleView : public LocationBarBubbleDelegateView,
// iOS promotion view.
DesktopIOSPromotionBubbleView* ios_promo_view_;
+ // Footnote view.
+ views::View* footnote_view_;
+
// When the destructor is invoked should the bookmark be removed?
bool remove_bookmark_;

Powered by Google App Engine
This is Rietveld 408576698