chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion_util.h - Issue 2803293002: Create Bookmark Footnote desktop iOS promotion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion_util.h

Issue 2803293002: Create Bookmark Footnote desktop iOS promotion (Closed)

Patch Set: win only Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion_footnote_delegate.h ('k') | chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion_util.h

diff --git a/chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion_util.h b/chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion_util.h

index 05da3a3a4e781bdffe884b4a81c9e21982554483..4adcc342c832b5481c18953e9f349b71efa31528 100644

--- a/chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion_util.h

+++ b/chrome/browser/ui/desktop_ios_promotion/desktop_ios_promotion_util.h

@@ -32,8 +32,9 @@ enum class PromotionDismissalReason {

NO_THANKS = 1,

CLOSE_BUTTON = 2,

SEND_SMS = 3,

+ LEARN_MORE = 4,

// Used for histograms logging.

- DISMISSAL_REASON_MAX_VALUE = 4

+ DISMISSAL_REASON_MAX_VALUE = 5

};

enum class EntryPointLocalPrefType { IMPRESSIONS = 0, DISMISSED = 1 };

@@ -48,8 +49,9 @@ enum class PromotionEntryPoint {

BOOKMARKS_BUBBLE = 2,

BOOKMARKS_FOOTNOTE = 3,

HISTORY_PAGE = 4,

+ FOOTNOTE_FOLLOWUP_BUBBLE = 5,

// Used for histograms logging.

- ENTRY_POINT_MAX_VALUE = 5

+ ENTRY_POINT_MAX_VALUE = 6

};

// Entry points local prefs, each entry point has a preference for impressions