[DevTools] Make screen-orientation-override agnostic to real screen orientation

[DevTools] Make screen-orientation-override agnostic to real screen orientation

The test is already pretty robust, but it mistakenly console.logs the
original orientation. Disabling logging solves the problem.

BUG=709426
Review-Url: https://codereview.chromium.org/2803233003
Cr-Commit-Position: refs/heads/master@{#463043}
Committed: https://chromium.googlesource.com/chromium/src/+/abc172e25ae45eae70f4891d12e6c76445857686

[dgozman, 2017-04-07 18:13:44]

dgozman@chromium.org changed reviewers:
+ lushnikov@chromium.org

[dgozman, 2017-04-07 18:13:45]

Could you please take a look?

[dgozman, 2017-04-07 18:13:48]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 18:14:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 19:34:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 19:34:53]

Dry run: This issue passed the CQ dry run.

[lushnikov, 2017-04-07 22:19:46]

https://codereview.chromium.org/2803233003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/inspector/screen-orientation-override.html
(right):

https://codereview.chromium.org/2803233003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/screen-orientation-override.html:27:
console.log(dump());
can we rather kill this all logic for dumping?

[dgozman, 2017-04-07 22:29:05]

https://codereview.chromium.org/2803233003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/inspector/screen-orientation-override.html
(right):

https://codereview.chromium.org/2803233003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/screen-orientation-override.html:27:
console.log(dump());
On 2017/04/07 22:19:46, lushnikov wrote:
> can we rather kill this all logic for dumping?

Sounds like extra movement for no benefit.

[lushnikov, 2017-04-07 22:38:25]

lgtm

[dgozman, 2017-04-07 22:41:06]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2017-04-07 22:41:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 23:21:11]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491604866453400, "parent_rev":
"8f5e90160be0556460c03c7cdfb91dd10016af28", "commit_rev":
"abc172e25ae45eae70f4891d12e6c76445857686"}

[commit-bot: I haz the power, 2017-04-07 23:22:03]

Description was changed from

==========
[DevTools] Make screen-orientation-override agnostic to real screen orientation

The test is already pretty robust, but it mistakenly console.logs the
original orientation. Disabling logging solves the problem.

BUG=709426
==========

to

==========
[DevTools] Make screen-orientation-override agnostic to real screen orientation

The test is already pretty robust, but it mistakenly console.logs the
original orientation. Disabling logging solves the problem.

BUG=709426

Review-Url: https://codereview.chromium.org/2803233003
Cr-Commit-Position: refs/heads/master@{#463043}
Committed:
https://chromium.googlesource.com/chromium/src/+/abc172e25ae45eae70f4891d12e6...
==========

[commit-bot: I haz the power, 2017-04-07 23:22:04]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/abc172e25ae45eae70f4891d12e6...