Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited.h

Issue 2803223002: Create a Most Visited tile for ContentSuggestions (Closed)
Patch Set: Reviewable Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited.h
diff --git a/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited.h b/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited.h
new file mode 100644
index 0000000000000000000000000000000000000000..c33942904264762310941ce021e214e76f1ea80f
--- /dev/null
+++ b/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited.h
@@ -0,0 +1,31 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CELLS_CONTENT_SUGGESTIONS_MOST_VISITED_H_
+#define IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CELLS_CONTENT_SUGGESTIONS_MOST_VISITED_H_
+
+#import <Foundation/Foundation.h>
+
+@class FaviconAttributes;
+class GURL;
+
+// Object representing a Most Visited suggestion.
+@interface ContentSuggestionsMostVisited : NSObject
+
+// URL of the Most Visited suggestion.
+@property(nonatomic, assign) GURL url;
lpromero 2017/04/07 10:58:22 I think this is a good occasion to test drive a so
gambard 2017/04/07 14:47:21 Done.
+// Title of the Most Visited suggestion.
+@property(nonatomic, copy, nullable) NSString* title;
+// Attributes used to display the favicon of the Most Visited suggestion.
+@property(nonatomic, strong, nullable) FaviconAttributes* attributes;
stkhapugin 2017/04/07 11:15:18 Should this really be nullable, given that Favicon
gambard 2017/04/07 14:47:21 Yes, the fetch for the attributes are asynchronous
stkhapugin 2017/04/10 11:17:37 Please document this behavior in a comment here an
gambard 2017/04/10 12:06:34 Done.
+
+// Returns a Most Visited with the properties set.
++ (nullable ContentSuggestionsMostVisited*)
+mostVisitedWithURL:(const GURL&)URL
+ title:(nullable NSString*)title
+ attributes:(nullable FaviconAttributes*)attributes;
+
+@end
+
+#endif // IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CELLS_CONTENT_SUGGESTIONS_MOST_VISITED_H_

Powered by Google App Engine
This is Rietveld 408576698