Create a Most Visited tile for ContentSuggestions

ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_most_visited.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CELLS_CONTENT_SUGGESTIONS_MOST_VISITED_H_
+#define IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CELLS_CONTENT_SUGGESTIONS_MOST_VISITED_H_
+
+#import <Foundation/Foundation.h>
+
+@class FaviconAttributes;
+class GURL;
+
+// Object representing a Most Visited suggestion.
+@interface ContentSuggestionsMostVisited : NSObject
+
+// URL of the Most Visited suggestion.
+@property(nonatomic, assign) GURL url;

[lpromero, 2017/04/07 10:58:22]

I think this is a good occasion to test drive a solution without GURL.

[gambard, 2017/04/07 14:47:21]

Done.

+// Title of the Most Visited suggestion.
+@property(nonatomic, copy, nullable) NSString* title;
+// Attributes used to display the favicon of the Most Visited suggestion.
+@property(nonatomic, strong, nullable) FaviconAttributes* attributes;

[stkhapugin, 2017/04/07 11:15:18]

Should this really be nullable, given that FaviconAttributes seem to support
both favicon and monogram configurations?

[gambard, 2017/04/07 14:47:21]

Yes, the fetch for the attributes are asynchronous, so at the beginning this can
be nil.
Configuring a favicon view with nil attributes ends up with a uniform grey
background with no letter.

[stkhapugin, 2017/04/10 11:17:37]

Please document this behavior in a comment here and/or on the cell class. 

[gambard, 2017/04/10 12:06:34]

Done.

+
+// Returns a Most Visited with the properties set.
++ (nullable ContentSuggestionsMostVisited*)
+mostVisitedWithURL:(const GURL&)URL
+             title:(nullable NSString*)title
+        attributes:(nullable FaviconAttributes*)attributes;
+
+@end
+
+#endif  // IOS_CHROME_BROWSER_UI_CONTENT_SUGGESTIONS_CELLS_CONTENT_SUGGESTIONS_MOST_VISITED_H_