Re-enable selectors4 tests from WPT repository

Re-enable selectors4 tests from WPT repository

As agreed on https://chromium-review.googlesource.com/465440
the tests that are considered manual due to the "interact" flag,
but that the feature hasn't been implemented yet ":focus-within"
are skipped for now.

There's one manual test "hover-001-manual.html"
that is also skipped in this patch.

BUG=706118
Review-Url: https://codereview.chromium.org/2803213002
Cr-Commit-Position: refs/heads/master@{#462982}
Committed: https://chromium.googlesource.com/chromium/src/+/333a624229a859b3388e4c6af0f29197709991a2

[Manuel Rego, 2017-04-07 09:06:35]

rego@igalia.com changed reviewers:
+ kojii@chromium.org, qyearsley@chromium.org

[Manuel Rego, 2017-04-07 09:06:36]

One more CL to re-enable some tests.

I'm wondering what we should do with manual tests like
external/wpt/css/selectors4/hover-001-manual.html.
At this point I'm skipping it, but not sure if that's
the current plan (I guess eventually they should be removed
and we won't import them by default).

[qyearsley, 2017-04-07 17:28:09]

On 2017/04/07 at 09:06:36, rego wrote:
> One more CL to re-enable some tests.
> 
> I'm wondering what we should do with manual tests like
> external/wpt/css/selectors4/hover-001-manual.html.
> At this point I'm skipping it, but not sure if that's
> the current plan (I guess eventually they should be removed
> and we won't import them by default).

So, in the past they weren't imported by default, but it turns out that some
"manual" tests can also be ref tests (they can also have a <link
rel="match"...>) or testharness tests (they can also import testharness.js we
inject JS into some manual pointerevents tests to automate them). So, the
strategy for now is to explicitly skip them (like you have done here); see
http://crbug.com/708241.

LGTM

[qyearsley, 2017-04-07 17:28:23]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 17:28:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 18:07:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 18:07:46]

Dry run: This issue passed the CQ dry run.

[Manuel Rego, 2017-04-07 20:02:08]

On 2017/04/07 17:28:09, qyearsley wrote:
> So, in the past they weren't imported by default, but it turns out that some
> "manual" tests can also be ref tests (they can also have a <link
> rel="match"...>) or testharness tests (they can also import testharness.js we
> inject JS into some manual pointerevents tests to automate them). So, the
> strategy for now is to explicitly skip them (like you have done here); see
> http://crbug.com/708241.

Ok, let's land this, but in this case the test has "interact" flag
and not reference nor a testharness test:
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/external/...
So it's a different thing, I'll review the bug next week.

Thanks for the review!

[Manuel Rego, 2017-04-07 20:02:14]

The CQ bit was checked by rego@igalia.com

[commit-bot: I haz the power, 2017-04-07 20:03:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 20:18:08]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491595334548540, "parent_rev":
"610c1e208e8eeca0206000a3c5d58b3b49f523c6", "commit_rev":
"333a624229a859b3388e4c6af0f29197709991a2"}

[commit-bot: I haz the power, 2017-04-07 20:18:56]

Description was changed from

==========
Re-enable selectors4 tests from WPT repository

As agreed on https://chromium-review.googlesource.com/465440
the tests that are considered manual due to the "interact" flag,
but that the feature hasn't been implemented yet ":focus-within"
are skipped for now.

There's one manual test "hover-001-manual.html"
that is also skipped in this patch.

BUG=706118
==========

to

==========
Re-enable selectors4 tests from WPT repository

As agreed on https://chromium-review.googlesource.com/465440
the tests that are considered manual due to the "interact" flag,
but that the feature hasn't been implemented yet ":focus-within"
are skipped for now.

There's one manual test "hover-001-manual.html"
that is also skipped in this patch.

BUG=706118

Review-Url: https://codereview.chromium.org/2803213002
Cr-Commit-Position: refs/heads/master@{#462982}
Committed:
https://chromium.googlesource.com/chromium/src/+/333a624229a859b3388e4c6af0f2...
==========

[commit-bot: I haz the power, 2017-04-07 20:18:57]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/333a624229a859b3388e4c6af0f2...

[Manuel Rego, 2017-04-10 08:51:53]

On 2017/04/07 20:02:08, Manuel Rego wrote:
> On 2017/04/07 17:28:09, qyearsley wrote:
> > So, in the past they weren't imported by default, but it turns out that some
> > "manual" tests can also be ref tests (they can also have a <link
> > rel="match"...>) or testharness tests (they can also import testharness.js
we
> > inject JS into some manual pointerevents tests to automate them). So, the
> > strategy for now is to explicitly skip them (like you have done here); see
> > http://crbug.com/708241.
> 
> Ok, let's land this, but in this case the test has "interact" flag
> and not reference nor a testharness test:
>
https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/external/...
> So it's a different thing, I'll review the bug next week.

Ok, reading the bug properly now, this case is already considered. Thanks.