Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 2803203003: Revert of Migrate IME state update flow (Closed)

Created:
3 years, 8 months ago by Changwan Ryu
Modified:
3 years, 8 months ago
Reviewers:
Ted C, Jinsuk Kim, boliu
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, agrieve+watch_chromium.org, James Su, android-webview-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Migrate IME state update flow (patchset #4 id:100001 of https://codereview.chromium.org/2777223004/ ) Reason for revert: This patchset caused a regression crbug.com/709349: 'cut' option disappeared from webview selection pop up. Original issue's description: > Migrate IME state update flow > > Refactored the flow for IME state update so it bypasses CVCImpl > and go straight from RWHVA -> ImeAdapter native -> Java layer. > > Other related changes are: > > ImeAdapter provides EventObserver to reduce the dependency on CVC, > based on the suggestion made in https://goo.gl/pdtQCl. It is used > by an embedder (Chrome) and CVC to deal with IME notification. > This replaces IME state update done through CVC. Only the necessary > info (node editability, password attribute) are passed. > > ImeAdapter.ImeAdapterDelegate is to delegate some work upon IME > events. But it is used by ContentViewCore only, and there is no > clear benefit of having the interface. It was removed for > simplification. All the stuff can be (and are now) handled inside > ImeAdapter. > > BUG=662908, 626765, 620172 > > Review-Url: https://codereview.chromium.org/2777223004 > Cr-Commit-Position: refs/heads/master@{#462419} > Committed: https://chromium.googlesource.com/chromium/src/+/cc9e77e7d9e05da0f6017f1bdea024f0ce669786 TBR=boliu@chromium.org,tedchoc@chromium.org,jinsukkim@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=662908, 626765, 620172 Review-Url: https://codereview.chromium.org/2803203003 Cr-Commit-Position: refs/heads/master@{#463053} Committed: https://chromium.googlesource.com/chromium/src/+/ee89226f5c1820a579f50147cbfaf7df9462a0a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+374 lines, -337 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsGarbageCollectionTest.java View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 3 chunks +14 lines, -17 lines 0 comments Download
M content/browser/android/content_view_core_impl.h View 1 chunk +11 lines, -0 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M content/browser/android/ime_adapter_android.h View 2 chunks +0 lines, -3 lines 0 comments Download
M content/browser/android/ime_adapter_android.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M content/public/android/BUILD.gn View 3 chunks +1 line, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 17 chunks +157 lines, -33 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/ViewUtils.java View 1 chunk +0 lines, -24 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java View 22 chunks +108 lines, -208 lines 0 comments Download
D content/public/android/java/src/org/chromium/content_public/browser/ImeEventObserver.java View 1 chunk +0 lines, -22 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/PopupZoomerTest.java View 2 chunks +10 lines, -5 lines 0 comments Download
A content/public/android/javatests/src/org/chromium/content/browser/input/TestImeAdapterDelegate.java View 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Changwan Ryu
Created Revert of Migrate IME state update flow
3 years, 8 months ago (2017-04-07 22:30:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803203003/1
3 years, 8 months ago (2017-04-07 22:30:55 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 23:43:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ee89226f5c1820a579f50147cbfa...

Powered by Google App Engine
This is Rietveld 408576698