Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 2803193002: Re-order bluetooth name:UUID pairs by ascending UUID (Closed)

Created:
3 years, 8 months ago by deejay
Modified:
3 years, 8 months ago
CC:
chromium-reviews, haraken, blink-reviews, scheib+watch_chromium.org, ortuno+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-order bluetooth name:UUID pairs by ascending UUID Previous bluetooth UUIDs are listed in alphabetical order. We re-order by UUID rather than alphabetically to make comparisons against the authoritative lists [1][2][3] easier. Also one missing value is updated on characteristics. - object_type / 0x2ABF [1] https://www.bluetooth.com/specifications/gatt/services [2] https://www.bluetooth.com/specifications/gatt/characteristics [3] https://www.bluetooth.com/specifications/gatt/descriptors BUG=517115 Review-Url: https://codereview.chromium.org/2803193002 Cr-Commit-Position: refs/heads/master@{#463117} Committed: https://chromium.googlesource.com/chromium/src/+/969287a6341cee8881bd38c1a9019e8c80669d73

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -194 lines) Patch
M third_party/WebKit/Source/modules/bluetooth/BluetoothUUID.cpp View 2 chunks +195 lines, -194 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
deejay
Hi ortuno, Now I've updated for ordering patch-set. Please take a look this!
3 years, 8 months ago (2017-04-07 07:03:41 UTC) #3
scheib
Thank you. I've verified by extracting changed lines of diffs and sorting both the before/after ...
3 years, 8 months ago (2017-04-08 01:25:09 UTC) #5
scheib
lgtm
3 years, 8 months ago (2017-04-08 01:25:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803193002/1
3 years, 8 months ago (2017-04-08 01:25:38 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-08 03:07:16 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/969287a6341cee8881bd38c1a901...

Powered by Google App Engine
This is Rietveld 408576698