Revert of Move getUserMedia finish to "when audio track configured".

Revert of Move getUserMedia finish to "when audio track configured". (patchset #7 id:120001 of https://codereview.chromium.org/2777583002/ )

Reason for revert:
The added DCHECK(format_is_set()) is failing in MediaStreamTrack-getSettings.html

BUG=709188
Original issue's description:
> Move getUserMedia finish to "when audio track configured".
> 
> Previously, getUserMedia() would complete as soon as the sources
> were initialized - which did not do all the initialization.
> This CL will make getUserMedia() return when the track has been
> told of its configuration through OnSetFormat() from upstream.
> 
> This will allow GetSettings() to read the audio configuration from
> the track without worrying about whether the configuration is
> propagated or not.
> 
> BUG=704918
> 
> Review-Url: https://codereview.chromium.org/2777583002
> Cr-Commit-Position: refs/heads/master@{#462523}
> Committed: https://chromium.googlesource.com/chromium/src/+/a52d69d1877b170684041bed04d28acced85e40d

TBR=guidou@chromium.org,hta@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=704918
Review-Url: https://codereview.chromium.org/2803183002
Cr-Commit-Position: refs/heads/master@{#462797}
Committed: https://chromium.googlesource.com/chromium/src/+/35aeae1c6f63abb9a4cbb23f497a523349db7aa8

[foolip, 2017-04-07 05:20:39]

The CQ bit was checked by foolip@chromium.org

[foolip, 2017-04-07 05:20:39]

Created Revert of Move getUserMedia finish to "when audio track configured".

[commit-bot: I haz the power, 2017-04-07 05:20:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 05:33:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 05:33:07]

Failed to apply patch for content/renderer/media/media_stream_audio_unittest.cc:
While running git apply --index -3 -p1;
  error: patch failed: content/renderer/media/media_stream_audio_unittest.cc:460
  Falling back to three-way merge...
  Applied patch to 'content/renderer/media/media_stream_audio_unittest.cc' with
conflicts.
  U content/renderer/media/media_stream_audio_unittest.cc

Patch:       content/renderer/media/media_stream_audio_unittest.cc
Index: content/renderer/media/media_stream_audio_unittest.cc
diff --git a/content/renderer/media/media_stream_audio_unittest.cc
b/content/renderer/media/media_stream_audio_unittest.cc
index
225e87b2cb09531d653169236dc3350ea9740240..7026025e403cfd68ad788b2de485a4f1b1f3bb5e
100644
--- a/content/renderer/media/media_stream_audio_unittest.cc
+++ b/content/renderer/media/media_stream_audio_unittest.cc
@@ -6,7 +6,6 @@
 
 #include "base/atomicops.h"
 #include "base/message_loop/message_loop.h"
-#include "base/run_loop.h"
 #include "base/synchronization/lock.h"
 #include "base/synchronization/waitable_event.h"
 #include "base/test/test_timeouts.h"
@@ -17,7 +16,6 @@
 #include "content/renderer/media/media_stream_audio_track.h"
 #include "media/base/audio_bus.h"
 #include "media/base/audio_parameters.h"
-#include "media/base/bind_to_current_loop.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/WebKit/public/platform/WebString.h"
 #include "third_party/WebKit/public/web/WebHeap.h"
@@ -241,9 +239,6 @@
 }  // namespace
 
 class MediaStreamAudioTest : public ::testing::Test {
- public:
-  void CallbackFunction() { callback_is_called_ = true; }
-
  protected:
   void SetUp() override {
     blink_audio_source_.initialize(blink::WebString::fromUTF8("audio_id"),
@@ -273,8 +268,6 @@
   blink::WebMediaStreamTrack blink_audio_track_;
 
   base::MessageLoop message_loop_;
-
-  bool callback_is_called_ = false;
 };
 
 // Tests that a simple source-->track-->sink connection and audio data flow
@@ -460,31 +453,4 @@
   track()->RemoveSink(&sink);
 }
 
-// Tests that a callback is fired when initialization completes on a track.
-TEST_F(MediaStreamAudioTest, CallbackOnTrackInitialization) {
-  // Create a source, connect it to track, and connect the track to a
-  // sink.
-  blink_audio_source_.setExtraData(new FakeMediaStreamAudioSource());
-  ASSERT_TRUE(source());
-  EXPECT_TRUE(source()->ConnectToTrack(blink_audio_track_));
-  ASSERT_TRUE(track());
-  FakeMediaStreamAudioSink sink;
-  ASSERT_TRUE(!sink.params().IsValid());
-  track()->AddSink(&sink);
-  // The test callback is not thread-safe, so needs to be called on the
-  // current thread, not the thread from which it is triggered.
-  track()->SetFormatConfiguredCallback(media::BindToCurrentLoop(base::Bind(
-      &MediaStreamAudioTest::CallbackFunction, base::Unretained(this))));
-  EXPECT_FALSE(callback_is_called_);
-  // Wait until valid parameters are propagated to the sink, and then confirm
-  // the parameters are correct at the track and the sink.
-  while (!sink.params().IsValid())
-    base::PlatformThread::Sleep(TestTimeouts::tiny_timeout());
-  // Since the callback is waiting to run on this thread, we have to run
-  // an event loop.
-  base::RunLoop().RunUntilIdle();
-  EXPECT_TRUE(callback_is_called_);
-  track()->RemoveSink(&sink);
-}
-
 }  // namespace content

[foolip, 2017-04-07 06:41:03]

The CQ bit was checked by foolip@chromium.org

[commit-bot: I haz the power, 2017-04-07 06:41:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 06:45:03]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491547263977520, "parent_rev":
"c0bd568be938a133c8c58b92e8e8468368b4b838", "commit_rev":
"35aeae1c6f63abb9a4cbb23f497a523349db7aa8"}

[commit-bot: I haz the power, 2017-04-07 06:46:10]

Description was changed from

==========
Revert of Move getUserMedia finish to "when audio track configured". (patchset
#7 id:120001 of https://codereview.chromium.org/2777583002/ )

Reason for revert:
The added DCHECK(format_is_set()) is failing in
MediaStreamTrack-getSettings.html

BUG=709188

Original issue's description:
> Move getUserMedia finish to "when audio track configured".
> 
> Previously, getUserMedia() would complete as soon as the sources
> were initialized - which did not do all the initialization.
> This CL will make getUserMedia() return when the track has been
> told of its configuration through OnSetFormat() from upstream.
> 
> This will allow GetSettings() to read the audio configuration from
> the track without worrying about whether the configuration is
> propagated or not.
> 
> BUG=704918
> 
> Review-Url: https://codereview.chromium.org/2777583002
> Cr-Commit-Position: refs/heads/master@{#462523}
> Committed:
https://chromium.googlesource.com/chromium/src/+/a52d69d1877b170684041bed04d2...

TBR=guidou@chromium.org,hta@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=704918
==========

to

==========
Revert of Move getUserMedia finish to "when audio track configured". (patchset
#7 id:120001 of https://codereview.chromium.org/2777583002/ )

Reason for revert:
The added DCHECK(format_is_set()) is failing in
MediaStreamTrack-getSettings.html

BUG=709188

Original issue's description:
> Move getUserMedia finish to "when audio track configured".
> 
> Previously, getUserMedia() would complete as soon as the sources
> were initialized - which did not do all the initialization.
> This CL will make getUserMedia() return when the track has been
> told of its configuration through OnSetFormat() from upstream.
> 
> This will allow GetSettings() to read the audio configuration from
> the track without worrying about whether the configuration is
> propagated or not.
> 
> BUG=704918
> 
> Review-Url: https://codereview.chromium.org/2777583002
> Cr-Commit-Position: refs/heads/master@{#462523}
> Committed:
https://chromium.googlesource.com/chromium/src/+/a52d69d1877b170684041bed04d2...

TBR=guidou@chromium.org,hta@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=704918

Review-Url: https://codereview.chromium.org/2803183002
Cr-Commit-Position: refs/heads/master@{#462797}
Committed:
https://chromium.googlesource.com/chromium/src/+/35aeae1c6f63abb9a4cbb23f497a...
==========

[commit-bot: I haz the power, 2017-04-07 06:46:11]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/35aeae1c6f63abb9a4cbb23f497a...