Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2803163002: Move address parser and prefixes to android_webview/. (Closed)

Created:
3 years, 8 months ago by aelias_OOO_until_Jul13
Modified:
3 years, 8 months ago
CC:
agrieve+watch_chromium.org, android-webview-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move address parser and prefixes to android_webview/. After the content detectors were removed, the only remaining users of these are in WebView (and we don't want to add any other users for this primitive, legacy address parser) so move the files there and adjust namespaces. BUG=462596 Review-Url: https://codereview.chromium.org/2803163002 Cr-Commit-Position: refs/heads/master@{#463360} Committed: https://chromium.googlesource.com/chromium/src/+/8ea1dd5dc0c376016824320d131926fb889c77ba

Patch Set 1 #

Patch Set 2 : Fix glue layer compile #

Patch Set 3 : ContentViewMiscTest #

Patch Set 4 : Bring back ContentViewStatics import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+777 lines, -1750 lines) Patch
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java View 1 2 chunks +1 line, -2 lines 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwContentsStatics.java View 2 chunks +16 lines, -0 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/ContentViewMiscTest.java View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M android_webview/native/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
A + android_webview/native/address_parser.h View 2 chunks +9 lines, -10 lines 0 comments Download
A + android_webview/native/address_parser.cc View 11 chunks +18 lines, -21 lines 0 comments Download
A + android_webview/native/address_parser_internal.h View 5 chunks +15 lines, -16 lines 0 comments Download
A android_webview/native/address_parser_internal.cc View 1 chunk +670 lines, -0 lines 0 comments Download
A + android_webview/native/address_parser_unittest.cc View 5 chunks +20 lines, -18 lines 0 comments Download
M android_webview/native/aw_contents_statics.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M android_webview/renderer/aw_render_frame_ext.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M android_webview/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/android/content_view_statics.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M content/common/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
D content/common/android/address_parser.h View 1 chunk +0 lines, -37 lines 0 comments Download
D content/common/android/address_parser.cc View 1 chunk +0 lines, -228 lines 0 comments Download
D content/common/android/address_parser_internal.h View 1 chunk +0 lines, -90 lines 0 comments Download
D content/common/android/address_parser_internal.cc View 1 chunk +0 lines, -640 lines 0 comments Download
D content/common/android/address_parser_unittest.cc View 1 chunk +0 lines, -610 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewStatics.java View 2 chunks +0 lines, -18 lines 0 comments Download
M content/public/renderer/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D content/public/renderer/android_content_detection_prefixes.h View 1 chunk +0 lines, -21 lines 0 comments Download
D content/public/renderer/android_content_detection_prefixes.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 26 (20 generated)
aelias_OOO_until_Jul13
Hi sgurun@, PTAL.
3 years, 8 months ago (2017-04-07 23:10:32 UTC) #17
sgurun-gerrit only
On 2017/04/07 23:10:32, aelias wrote: > Hi sgurun@, PTAL. lgtm, not that we are thinking ...
3 years, 8 months ago (2017-04-08 01:10:34 UTC) #18
aelias_OOO_until_Jul13
+alexmos@ for more pure code removal in content/
3 years, 8 months ago (2017-04-08 01:12:46 UTC) #20
alexmos
LGTM
3 years, 8 months ago (2017-04-10 16:46:13 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803163002/60001
3 years, 8 months ago (2017-04-10 18:07:18 UTC) #23
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 19:30:08 UTC) #26
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8ea1dd5dc0c376016824320d1319...

Powered by Google App Engine
This is Rietveld 408576698