Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2803153002: [CrOS Tether] Refactor BleScanner so that it takes a BluetoothAdapter in its constructor instead of… (Closed)

Created:
3 years, 8 months ago by Kyle Horimoto
Modified:
3 years, 8 months ago
CC:
chromium-reviews, jlklein+watch-tether_chromium.org, tengs+watch-tether_chromium.org, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, oshima+watch_chromium.org, khorimoto+watch-tether_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CrOS Tether] Refactor BleScanner so that it takes a BluetoothAdapter in its constructor instead of constructing it itself. The tether module will have a shared adapter passed to all classes which need it. BUG=672263 Review-Url: https://codereview.chromium.org/2803153002 Cr-Commit-Position: refs/heads/master@{#462752} Committed: https://chromium.googlesource.com/chromium/src/+/a5023a0e9ba7b9f0c3137d90a3a830ecfb362414

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -178 lines) Patch
M chromeos/components/tether/ble_connection_manager.h View 2 chunks +14 lines, -13 lines 0 comments Download
M chromeos/components/tether/ble_connection_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chromeos/components/tether/ble_connection_manager_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chromeos/components/tether/ble_scanner.h View 3 chunks +12 lines, -19 lines 0 comments Download
M chromeos/components/tether/ble_scanner.cc View 4 chunks +28 lines, -58 lines 0 comments Download
M chromeos/components/tether/ble_scanner_unittest.cc View 17 chunks +20 lines, -83 lines 0 comments Download
M chromeos/components/tether/fake_ble_connection_manager.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
Kyle Horimoto
3 years, 8 months ago (2017-04-07 01:19:02 UTC) #2
Ryan Hansberry
lgtm
3 years, 8 months ago (2017-04-07 01:29:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803153002/1
3 years, 8 months ago (2017-04-07 01:30:32 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-07 01:30:34 UTC) #7
kkhorimoto
lgtm
3 years, 8 months ago (2017-04-07 01:52:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803153002/1
3 years, 8 months ago (2017-04-07 01:52:42 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 04:55:03 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a5023a0e9ba7b9f0c3137d90a3a8...

Powered by Google App Engine
This is Rietveld 408576698