third_party/WebKit/Source/platform/audio/ReverbInputBuffer.cpp - Issue 2803073002: Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in platform/audio

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/audio/ReverbInputBuffer.cpp

Issue 2803073002: Convert RELEASE_ASSERT()/ASSERT(...) to CHECK()/DCHECK_op(...) in platform/audio (Closed)

Patch Set: Removing DCHECK_IS_ON from FFTFrameOpenMAXDLAndroid.cpp Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/audio/ReverbInputBuffer.cpp

diff --git a/third_party/WebKit/Source/platform/audio/ReverbInputBuffer.cpp b/third_party/WebKit/Source/platform/audio/ReverbInputBuffer.cpp

index ef1f7faebc946eb02004ff8e5ee4d52b45eebd47..8838bdd264b4e17b1f140bd3f02a4656830bc2ff 100644

--- a/third_party/WebKit/Source/platform/audio/ReverbInputBuffer.cpp

+++ b/third_party/WebKit/Source/platform/audio/ReverbInputBuffer.cpp

@@ -44,7 +44,7 @@ void ReverbInputBuffer::write(const float* sourceP, size_t numberOfFrames) {

sizeof(float) * numberOfFrames);

m_writeIndex += numberOfFrames;

- ASSERT(m_writeIndex <= bufferLength);

+ DCHECK_LE(m_writeIndex, bufferLength);

if (m_writeIndex >= bufferLength)

m_writeIndex = 0;