Fix leaking NewTabPageView(s).

Fix leaking NewTabPageView(s).

The problem is that it was registering as a TabObserver but
not removing itself.  This moves the TabObserver logic into
NewTabPage, which does handle proper clean up.

BUG=708710
Review-Url: https://codereview.chromium.org/2803063003
Cr-Commit-Position: refs/heads/master@{#462741}
Committed: https://chromium.googlesource.com/chromium/src/+/2daf853b6542cd08c23618991790870c07fb91f4

[Ted C, 2017-04-06 23:41:12]

tedchoc@chromium.org changed reviewers:
+ bauerb@chromium.org, dgn@chromium.org, ssid@chromium.org

[Ted C, 2017-04-06 23:41:13]

PTAL

bauerb||dgn - NTP
ssid to see if this addresses the leak

[ssid, 2017-04-07 00:01:19]

lgtm, this fixes the leak

[Bernhard Bauer, 2017-04-07 00:58:19]

LGTM, thanks!

[Ted C, 2017-04-07 01:04:23]

The CQ bit was checked by tedchoc@chromium.org

[commit-bot: I haz the power, 2017-04-07 01:05:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 01:51:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491527063986130,
"parent_rev": "4d188dd210489eb0a70bd66af0a1cf1400331399", "commit_rev":
"2daf853b6542cd08c23618991790870c07fb91f4"}

[commit-bot: I haz the power, 2017-04-07 01:52:03]

Description was changed from

==========
Fix leaking NewTabPageView(s).

The problem is that it was registering as a TabObserver but
not removing itself.  This moves the TabObserver logic into
NewTabPage, which does handle proper clean up.

BUG=708710
==========

to

==========
Fix leaking NewTabPageView(s).

The problem is that it was registering as a TabObserver but
not removing itself.  This moves the TabObserver logic into
NewTabPage, which does handle proper clean up.

BUG=708710

Review-Url: https://codereview.chromium.org/2803063003
Cr-Commit-Position: refs/heads/master@{#462741}
Committed:
https://chromium.googlesource.com/chromium/src/+/2daf853b6542cd08c23618991790...
==========

[commit-bot: I haz the power, 2017-04-07 01:52:03]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2daf853b6542cd08c23618991790...

[dgn, 2017-04-07 08:49:09]

On 2017/04/07 01:52:03, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:20001) as
>
https://chromium.googlesource.com/chromium/src/+/2daf853b6542cd08c23618991790...

lgtm, thanks! Does that also fix https://crbug.com/708836 ?

[Ted C, 2017-04-07 16:32:30]

On 2017/04/07 08:49:09, dgn wrote:
> On 2017/04/07 01:52:03, commit-bot: I haz the power wrote:
> > Committed patchset #2 (id:20001) as
> >
>
https://chromium.googlesource.com/chromium/src/+/2daf853b6542cd08c23618991790...
> 
> lgtm, thanks! Does that also fix https://crbug.com/708836 ?

I suspect it does fix that as well.  We had the potential to hold onto
a lot of memory with this, so OOMs were much more likely.

Fingers crossed it is an easy fix.