Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2803023004: Make HttpStreamFactoryImpl::Job::|using_ssl_| const (Closed)

Created:
3 years, 8 months ago by xunjieli
Modified:
3 years, 8 months ago
Reviewers:
Bence
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make HttpStreamFactoryImpl::Job::|using_ssl_| const Make |using_ssl_| a const. This makes the code slightly easier to read. BUG=475060 Review-Url: https://codereview.chromium.org/2803023004 Cr-Commit-Position: refs/heads/master@{#462708} Committed: https://chromium.googlesource.com/chromium/src/+/fdc46cfd39b463ced32077a238009083e159ae79

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M net/http/http_stream_factory_impl_job.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
xunjieli
3 years, 8 months ago (2017-04-06 22:29:27 UTC) #5
Bence
LGTM. Nice!
3 years, 8 months ago (2017-04-06 23:50:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803023004/1
3 years, 8 months ago (2017-04-06 23:51:00 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 00:31:19 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fdc46cfd39b463ced32077a23800...

Powered by Google App Engine
This is Rietveld 408576698