Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2803023002: Add calls to WrapCurrentThread and UnwrapCurrentThread. (Closed)

Created:
3 years, 8 months ago by nisse-chromium (ooo August 14)
Modified:
3 years, 8 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, kjellander_chromium
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add calls to WrapCurrentThread and UnwrapCurrentThread. Needed after the move of the rtc::Task class and its tests, because webrtc in chrome is built with NO_MAIN_THREAD_WRAPPING. BUG=708968 Review-Url: https://codereview.chromium.org/2803023002 Cr-Commit-Position: refs/heads/master@{#462802} Committed: https://chromium.googlesource.com/chromium/src/+/679c2b37f46e5542996e26304218bf922a4eb43e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/libjingle_xmpp/task_runner/task_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
nisse-chromium (ooo August 14)
Sergey, can you review this, or does it have to wait until Tommi is back ...
3 years, 8 months ago (2017-04-06 14:07:44 UTC) #2
Sergey Ulanov
lgtm
3 years, 8 months ago (2017-04-06 18:05:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2803023002/1
3 years, 8 months ago (2017-04-07 06:55:43 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 07:33:44 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/679c2b37f46e5542996e26304218...

Powered by Google App Engine
This is Rietveld 408576698