Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp

Issue 2803013005: Deduplicating compositing scrollingCoordinator helper (Closed)
Patch Set: Rebased post blink rename Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp
diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp
index bba2e2e14b3bc001ddab3355c7226ed92ac41afb..51c691e373526c103a95a5264b8f81bd95c46b9b 100644
--- a/third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp
+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp
@@ -273,11 +273,6 @@ void CompositingLayerAssigner::UpdateSquashingAssignment(
}
}
-static ScrollingCoordinator* ScrollingCoordinatorFromLayer(PaintLayer& layer) {
- Page* page = layer.GetLayoutObject().GetFrame()->GetPage();
- return (!page) ? nullptr : page->GetScrollingCoordinator();
-}
-
void CompositingLayerAssigner::AssignLayersToBackingsInternal(
PaintLayer* layer,
SquashingState& squashing_state,
@@ -302,7 +297,7 @@ void CompositingLayerAssigner::AssignLayersToBackingsInternal(
layers_needing_paint_invalidation.push_back(layer);
layers_changed_ = true;
if (ScrollingCoordinator* scrolling_coordinator =
- ScrollingCoordinatorFromLayer(*layer)) {
+ layer->GetScrollingCoordinator()) {
if (layer->GetLayoutObject().Style()->HasViewportConstrainedPosition()) {
scrolling_coordinator->FrameViewFixedObjectsDidChange(
layer->GetLayoutObject().View()->GetFrameView());

Powered by Google App Engine
This is Rietveld 408576698