Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

Issue 2803013005: Deduplicating compositing scrollingCoordinator helper (Closed)
Patch Set: Rebased post blink rename Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
index 43f5f0190fd2678de5a19e949f3e60755cbd3f5d..15a6eac4647ddcbb72fef80a1eefeaa6995f8b67 100644
--- a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
+++ b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
@@ -160,13 +160,6 @@ static inline bool IsAcceleratedContents(LayoutObject& layout_object) {
layout_object.IsVideo();
}
-// Get the scrolling coordinator in a way that works inside
-// CompositedLayerMapping's destructor.
-static ScrollingCoordinator* ScrollingCoordinatorFromLayer(PaintLayer& layer) {
- Page* page = layer.GetLayoutObject().GetFrame()->GetPage();
- return (!page) ? nullptr : page->GetScrollingCoordinator();
-}
-
CompositedLayerMapping::CompositedLayerMapping(PaintLayer& layer)
: owning_layer_(layer),
content_offset_in_compositing_layer_dirty_(false),
@@ -1604,7 +1597,7 @@ void CompositedLayerMapping::RegisterScrollingLayers() {
// Register fixed position layers and their containers with the scrolling
// coordinator.
ScrollingCoordinator* scrolling_coordinator =
- ScrollingCoordinatorFromLayer(owning_layer_);
+ owning_layer_.GetScrollingCoordinator();
if (!scrolling_coordinator)
return;
@@ -1939,7 +1932,7 @@ bool CompositedLayerMapping::ToggleScrollbarLayerIfNeeded(
if (PaintLayerScrollableArea* scrollable_area =
owning_layer_.GetScrollableArea()) {
if (ScrollingCoordinator* scrolling_coordinator =
- ScrollingCoordinatorFromLayer(owning_layer_)) {
+ owning_layer_.GetScrollingCoordinator()) {
if (reason == kCompositingReasonLayerForHorizontalScrollbar)
scrolling_coordinator->ScrollableAreaScrollbarLayerDidChange(
scrollable_area, kHorizontalScrollbar);
@@ -2375,7 +2368,7 @@ void CompositedLayerMapping::UpdateChildClippingMaskLayer(
bool CompositedLayerMapping::UpdateScrollingLayers(
bool needs_scrolling_layers) {
ScrollingCoordinator* scrolling_coordinator =
- ScrollingCoordinatorFromLayer(owning_layer_);
+ owning_layer_.GetScrollingCoordinator();
bool layer_changed = false;
if (needs_scrolling_layers) {
@@ -2438,7 +2431,7 @@ static void UpdateScrollParentForGraphicsLayer(
void CompositedLayerMapping::UpdateScrollParent(
const PaintLayer* scroll_parent) {
if (ScrollingCoordinator* scrolling_coordinator =
- ScrollingCoordinatorFromLayer(owning_layer_)) {
+ owning_layer_.GetScrollingCoordinator()) {
GraphicsLayer* topmost_layer = ChildForSuperlayers();
UpdateScrollParentForGraphicsLayer(squashing_containment_layer_.get(),
topmost_layer, scroll_parent,
@@ -2481,7 +2474,7 @@ void CompositedLayerMapping::UpdateClipParent(const PaintLayer* scroll_parent) {
}
if (ScrollingCoordinator* scrolling_coordinator =
- ScrollingCoordinatorFromLayer(owning_layer_)) {
+ owning_layer_.GetScrollingCoordinator()) {
GraphicsLayer* topmost_layer = ChildForSuperlayers();
UpdateClipParentForGraphicsLayer(squashing_containment_layer_.get(),
topmost_layer, clip_parent,
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/compositing/CompositingLayerAssigner.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698