Issue 2803013004: Mark optimized code for the crash handler and disassembler output.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2803013004: Mark optimized code for the crash handler and disassembler output. (Closed)

Created:
3 years, 8 months ago by rmacnak

Modified:
3 years, 8 months ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Mark optimized code for the crash handler and disassembler output. Optimized code has its function name prefixed with an asterisk, which is also how we display optimized code in Observatory. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/daddec8308c79a8b22216042b9ee9345d8b2872e

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -48 lines)			Patch
M	runtime/vm/disassembler.cc	View		6 chunks	+21 lines, -19 lines	0 comments	Download
M	runtime/vm/object.cc	View		1 chunk	+17 lines, -21 lines	0 comments	Download
M	runtime/vm/profiler_test.cc	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/stack_frame.cc	View		1 chunk	+5 lines, -4 lines	0 comments	Download

Total messages: 5 (2 generated)

rmacnak

3 years, 8 months ago (2017-04-07 20:32:01 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
daddec8308c79a8b22216042b9ee9345d8b2872e (presubmit successful).