Mark optimized code for the crash handler and disassembler output.

runtime/vm/disassembler.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/disassembler.h"
 
 #include "vm/assembler.h"
 #include "vm/deopt_instructions.h"
 #include "vm/globals.h"
 #include "vm/il_printer.h"
@@ skipping 145 matching lines @@
                                   human_buffer, sizeof(human_buffer), object,
                                   pc);
     pc += instruction_length;
   }
 }
 
 
 void Disassembler::DisassembleCodeHelper(const char* function_fullname,
                                          const Code& code,
                                          bool optimized) {
-  LocalVarDescriptors& var_descriptors = LocalVarDescriptors::Handle();
+  Zone* zone = Thread::Current()->zone();
+  LocalVarDescriptors& var_descriptors = LocalVarDescriptors::Handle(zone);
   if (FLAG_print_variable_descriptors) {
     var_descriptors = code.GetLocalVarDescriptors();
   }
   THR_Print("Code for %sfunction '%s' {\n", optimized ? "optimized " : "",
             function_fullname);
   code.Disassemble();
   THR_Print("}\n");
 
 #if defined(TARGET_ARCH_IA32)
   THR_Print("Pointer offsets for function: {\n");
   // Pointer offsets are stored in descending order.
-  Object& obj = Object::Handle();
+  Object& obj = Object::Handle(zone);
   for (intptr_t i = code.pointer_offsets_length() - 1; i >= 0; i--) {
     const uword addr = code.GetPointerOffsetAt(i) + code.PayloadStart();
     obj = *reinterpret_cast<RawObject**>(addr);
     THR_Print(" %d : %#" Px " '%s'\n", code.GetPointerOffsetAt(i), addr,
               obj.ToCString());
   }
   THR_Print("}\n");
 #else
   ASSERT(code.pointer_offsets_length() == 0);
 #endif
 
-  const ObjectPool& object_pool = ObjectPool::Handle(code.GetObjectPool());
+  const ObjectPool& object_pool =
+      ObjectPool::Handle(zone, code.GetObjectPool());
   object_pool.DebugPrint();
 
   THR_Print("PC Descriptors for function '%s' {\n", function_fullname);
   PcDescriptors::PrintHeaderString();
   const PcDescriptors& descriptors =
-      PcDescriptors::Handle(code.pc_descriptors());
+      PcDescriptors::Handle(zone, code.pc_descriptors());
   THR_Print("%s}\n", descriptors.ToCString());
 
-  uword start = Instructions::Handle(code.instructions()).PayloadStart();
-  const Array& deopt_table = Array::Handle(code.deopt_info_array());
+  uword start = Instructions::Handle(zone, code.instructions()).PayloadStart();
+  const Array& deopt_table = Array::Handle(zone, code.deopt_info_array());
   intptr_t deopt_table_length = DeoptTable::GetLength(deopt_table);
   if (deopt_table_length > 0) {
     THR_Print("DeoptInfo: {\n");
-    Smi& offset = Smi::Handle();
-    TypedData& info = TypedData::Handle();
-    Smi& reason_and_flags = Smi::Handle();
+    Smi& offset = Smi::Handle(zone);
+    TypedData& info = TypedData::Handle(zone);
+    Smi& reason_and_flags = Smi::Handle(zone);
     for (intptr_t i = 0; i < deopt_table_length; ++i) {
       DeoptTable::GetEntry(deopt_table, i, &offset, &info, &reason_and_flags);
       const intptr_t reason =
           DeoptTable::ReasonField::decode(reason_and_flags.Value());
       ASSERT((0 <= reason) && (reason < ICData::kDeoptNumReasons));
       THR_Print(
           "%4" Pd ": 0x%" Px "  %s  (%s)\n", i, start + offset.Value(),
           DeoptInfo::ToCString(deopt_table, info),
           DeoptReasonToCString(static_cast<ICData::DeoptReasonId>(reason)));
     }
     THR_Print("}\n");
   }
 
   THR_Print("StackMaps for function '%s' {\n", function_fullname);
   if (code.stackmaps() != Array::null()) {
-    const Array& stackmap_table = Array::Handle(code.stackmaps());
-    StackMap& map = StackMap::Handle();
+    const Array& stackmap_table = Array::Handle(zone, code.stackmaps());
+    StackMap& map = StackMap::Handle(zone);
     for (intptr_t i = 0; i < stackmap_table.Length(); ++i) {
       map ^= stackmap_table.At(i);
       THR_Print("%s\n", map.ToCString());
     }
   }
   THR_Print("}\n");
 
   if (FLAG_print_variable_descriptors) {
     THR_Print("Variable Descriptors for function '%s' {\n", function_fullname);
     intptr_t var_desc_length =
         var_descriptors.IsNull() ? 0 : var_descriptors.Length();
-    String& var_name = String::Handle();
+    String& var_name = String::Handle(zone);
     for (intptr_t i = 0; i < var_desc_length; i++) {
       var_name = var_descriptors.GetName(i);
       RawLocalVarDescriptors::VarInfo var_info;
       var_descriptors.GetInfo(i, &var_info);
       const int8_t kind = var_info.kind();
       if (kind == RawLocalVarDescriptors::kSavedCurrentContext) {
         THR_Print("  saved current CTX reg offset %d\n", var_info.index());
       } else {
         if (kind == RawLocalVarDescriptors::kContextLevel) {
           THR_Print("  context level %d scope %d", var_info.index(),
                     var_info.scope_id);
         } else if (kind == RawLocalVarDescriptors::kStackVar) {
           THR_Print("  stack var '%s' offset %d", var_name.ToCString(),
                     var_info.index());
         } else {
           ASSERT(kind == RawLocalVarDescriptors::kContextVar);
           THR_Print("  context var '%s' level %d offset %d",
                     var_name.ToCString(), var_info.scope_id, var_info.index());
         }
         THR_Print(" (valid %s-%s)\n", var_info.begin_pos.ToCString(),
                   var_info.end_pos.ToCString());
       }
     }
     THR_Print("}\n");
   }
 
   THR_Print("Exception Handlers for function '%s' {\n", function_fullname);
   const ExceptionHandlers& handlers =
-      ExceptionHandlers::Handle(code.exception_handlers());
+      ExceptionHandlers::Handle(zone, code.exception_handlers());
   THR_Print("%s}\n", handlers.ToCString());
 
   {
     THR_Print("Static call target functions {\n");
-    const Array& table = Array::Handle(code.static_calls_target_table());
-    Smi& offset = Smi::Handle();
-    Function& function = Function::Handle();
-    Code& code = Code::Handle();
+    const Array& table = Array::Handle(zone, code.static_calls_target_table());
+    Smi& offset = Smi::Handle(zone);
+    Function& function = Function::Handle(zone);
+    Code& code = Code::Handle(zone);
     for (intptr_t i = 0; i < table.Length();
          i += Code::kSCallTableEntryLength) {
       offset ^= table.At(i + Code::kSCallTableOffsetEntry);
       function ^= table.At(i + Code::kSCallTableFunctionEntry);
       code ^= table.At(i + Code::kSCallTableCodeEntry);
       if (function.IsNull()) {
-        Class& cls = Class::Handle();
+        Class& cls = Class::Handle(zone);
         cls ^= code.owner();
         if (cls.IsNull()) {
           THR_Print("  0x%" Px ": %s, %p\n", start + offset.Value(),
-                    code.Name(), code.raw());
+                    code.QualifiedName(), code.raw());
         } else {
           THR_Print("  0x%" Px ": allocation stub for %s, %p\n",
                     start + offset.Value(), cls.ToCString(), code.raw());
         }
       } else {
         THR_Print("  0x%" Px ": %s, %p\n", start + offset.Value(),
                   function.ToFullyQualifiedCString(), code.raw());
       }
     }
     THR_Print("}\n");
@@ skipping 11 matching lines @@
                                    const Code& code,
                                    bool optimized) {
   const char* function_fullname = function.ToFullyQualifiedCString();
   DisassembleCodeHelper(function_fullname, code, optimized);
 }
 
 
 #endif  // !PRODUCT
 
 }  // namespace dart