Add SplitTextNodeCommandTest

Add SplitTextNodeCommandTest

I am planning to modify the behavior of DocumentMarkerController::copyMarkers()
(to move the markers to the new list instead of leaving pointers to the same
markers, which have possibly been modified, in the source list) and decided to
write a test to make sure we don't break SplitTextNodeCommand.

BUG=707867
Review-Url: https://codereview.chromium.org/2802993007
Cr-Commit-Position: refs/heads/master@{#463459}
Committed: https://chromium.googlesource.com/chromium/src/+/474939fc1d9344c7fdbbb12638d4d318e9c57192

[rlanday, 2017-04-08 02:18:36]

rlanday@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yosin@chromium.org

[Xiaocheng, 2017-04-08 02:38:19]

lgtm

https://codereview.chromium.org/2802993007/diff/1/third_party/WebKit/Source/c...
File
third_party/WebKit/Source/core/editing/commands/SplitTextNodeCommandTest.cpp
(right):

https://codereview.chromium.org/2802993007/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/SplitTextNodeCommandTest.cpp:69:
// TODO(rlanday): the truncated marker that spanned node boundaries is not
Do you really plan to fix it?

I don't see a clean fix right now.

[rlanday, 2017-04-08 06:00:21]

On 2017/04/08 at 02:38:19, xiaochengh wrote:
> lgtm
> 
>
https://codereview.chromium.org/2802993007/diff/1/third_party/WebKit/Source/c...
> File
third_party/WebKit/Source/core/editing/commands/SplitTextNodeCommandTest.cpp
(right):
> 
>
https://codereview.chromium.org/2802993007/diff/1/third_party/WebKit/Source/c...
>
third_party/WebKit/Source/core/editing/commands/SplitTextNodeCommandTest.cpp:69:
// TODO(rlanday): the truncated marker that spanned node boundaries is not
> Do you really plan to fix it?
> 
> I don't see a clean fix right now.

I think I know how to fix it but I don't know if it matters. Since right now,
markers can't overlap, there can be at most one marker that gets truncated, so
we could just store the address of the marker and the correct endpoint in
SplitTextNodeCommand, and then when we do an undo, check each marker to see if
it matches the pointer and fix the end offset if it does. To future-proof it for
Suggestion markers which can overlap, we could use a map where we store the
(address, endOffset) pairs for all truncated markers.

[yosin_UTC9, 2017-04-10 02:28:49]

lgtm

Thanks for adding test.
Please rebase for grate blink renaming.
dcheng@ will provide the tool for rebase w/ renaming.

[rlanday, 2017-04-10 20:57:58]

The CQ bit was checked by rlanday@chromium.org

[rlanday, 2017-04-10 20:57:59]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org,
xiaochengh@chromium.org
Link to the patchset: https://codereview.chromium.org/2802993007/#ps20001
(title: "Rebase on renaming")

[commit-bot: I haz the power, 2017-04-10 20:58:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 00:10:26]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491857878854300,
"parent_rev": "4a485532d97f667f4bdac8d81d992caf6e28872a", "commit_rev":
"474939fc1d9344c7fdbbb12638d4d318e9c57192"}

[commit-bot: I haz the power, 2017-04-11 00:12:53]

Description was changed from

==========
Add SplitTextNodeCommandTest

I am planning to modify the behavior of DocumentMarkerController::copyMarkers()
(to move the markers to the new list instead of leaving pointers to the same
markers, which have possibly been modified, in the source list) and decided to
write a test to make sure we don't break SplitTextNodeCommand.

BUG=707867
==========

to

==========
Add SplitTextNodeCommandTest

I am planning to modify the behavior of DocumentMarkerController::copyMarkers()
(to move the markers to the new list instead of leaving pointers to the same
markers, which have possibly been modified, in the source list) and decided to
write a test to make sure we don't break SplitTextNodeCommand.

BUG=707867

Review-Url: https://codereview.chromium.org/2802993007
Cr-Commit-Position: refs/heads/master@{#463459}
Committed:
https://chromium.googlesource.com/chromium/src/+/474939fc1d9344c7fdbbb12638d4...
==========

[commit-bot: I haz the power, 2017-04-11 00:12:54]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/474939fc1d9344c7fdbbb12638d4...