Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2802993002: Revert of Clear pseudoElement from ElementRareData when FirstLetterPseudoElement doesn't have a LayoutObject (Closed)

Created:
3 years, 8 months ago by foolip
Modified:
3 years, 8 months ago
Reviewers:
nainar, esprehn
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Clear pseudoElement from ElementRareData when FirstLetterPseudoElement doesn't have a LayoutObject (patchset #4 id:60001 of https://codereview.chromium.org/2752163003/ ) Reason for revert: The added test is failing on many platforms due to a mismatch between actual expected (not a crash). BUG=708967 Original issue's description: > Clear pseudoElement from ElementRareData when FirstLetterPseudoElement doesn't have a LayoutObject > > This patch edits Element::rebuildPseudoElementLayoutTree() to make sure > it mirrors Element::updatePseudoElement() called in > Element::recaclStyle() by calling Element::updateFirstLetter() in the > case the PseudoElement is firstLetter as is done in > Element::updateFirstLetter() to ensure we don't call > Element::retachLayoutTree() uncoditionally. > > Adds crash test and expectation as well. > > BUG=700655 > > Review-Url: https://codereview.chromium.org/2752163003 > Cr-Commit-Position: refs/heads/master@{#462373} > Committed: https://chromium.googlesource.com/chromium/src/+/6d202487ff823def4672599f51e9f13880e6b877 TBR=esprehn@chromium.org,nainar@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=700655 Review-Url: https://codereview.chromium.org/2802993002 Cr-Commit-Position: refs/heads/master@{#462413} Committed: https://chromium.googlesource.com/chromium/src/+/7773939ef302371795ef39138e10225f3d493aa1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -23 lines) Patch
D third_party/WebKit/LayoutTests/fast/css/crash-in-attachFirstLetterTextLayoutObjects.html View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/css/crash-in-attachFirstLetterTextLayoutObjects-expected.html View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 3 (2 generated)
foolip
3 years, 8 months ago (2017-04-06 10:17:48 UTC) #2
Created Revert of Clear pseudoElement from ElementRareData when
FirstLetterPseudoElement doesn't have a LayoutObject

Powered by Google App Engine
This is Rietveld 408576698