Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 2802983002: Rename FrameSelection::m_pendingSelection to m_layoutSelection (Closed)

Created:
3 years, 8 months ago by yoichio
Modified:
3 years, 8 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename FrameSelection::m_pendingSelection to m_layoutSelection TEST=No change in behavior BUG=708453 Review-Url: https://codereview.chromium.org/2802983002 Cr-Commit-Position: refs/heads/master@{#462411} Committed: https://chromium.googlesource.com/chromium/src/+/4a85cc3a3dd57a9811b794878a0056a27cbb058d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M third_party/WebKit/Source/core/editing/FrameSelection.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
yoichio
3 years, 8 months ago (2017-04-06 08:36:58 UTC) #4
yosin_UTC9
lgtm
3 years, 8 months ago (2017-04-06 08:48:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802983002/1
3 years, 8 months ago (2017-04-06 08:49:12 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 10:16:06 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4a85cc3a3dd57a9811b794878a00...

Powered by Google App Engine
This is Rietveld 408576698