Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2802973004: ReadingListProvider returns empty image (Closed)

Created:
3 years, 8 months ago by gambard
Modified:
3 years, 8 months ago
Reviewers:
jkrcal
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

ReadingListProvider returns empty image The Reading List provider does not have an image to provide to the UI. The FetchImage method runs the callback with an empty image. BUG=702241 Review-Url: https://codereview.chromium.org/2802973004 Cr-Commit-Position: refs/heads/master@{#462840} Committed: https://chromium.googlesource.com/chromium/src/+/15343e304623319dfd5612ac3d22930977a7e20c

Patch Set 1 #

Patch Set 2 : Fix include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M components/ntp_snippets/reading_list/reading_list_suggestions_provider.cc View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
gambard
PTAL.
3 years, 8 months ago (2017-04-07 11:09:19 UTC) #2
jkrcal
lgtm
3 years, 8 months ago (2017-04-07 11:14:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802973004/20001
3 years, 8 months ago (2017-04-07 11:16:36 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 12:00:10 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/15343e304623319dfd5612ac3d22...

Powered by Google App Engine
This is Rietveld 408576698