DevTools: Allow tab key to move focus when ConsolePrompt is empty

DevTools: Allow tab key to move focus when ConsolePrompt is empty

When navigating with keyboard, focus would get stuck in the ConsolePrompt.

BUG=706699
Review-Url: https://codereview.chromium.org/2802963002
Cr-Commit-Position: refs/heads/master@{#462769}
Committed: https://chromium.googlesource.com/chromium/src/+/e917c881c0102a752c52210df377116220b79733

[einbinder, 2017-04-06 07:42:33]

einbinder@chromium.org changed reviewers:
+ lushnikov@chromium.org

[einbinder, 2017-04-06 07:42:34]

ptal

https://codereview.chromium.org/2802963002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorTextEditor.js
(left):

https://codereview.chromium.org/2802963002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorTextEditor.js:173:
this.element.addEventListener('focus', this._handleElementFocus.bind(this),
false);
Trying to manage focus ourselves doesn't play nice with CodeMirror. This code
isn't needed after setting the tabIndex option.

[lushnikov, 2017-04-06 20:42:23]

lgtm

let's add a more descriptive text in the CL to outline motivation

[einbinder, 2017-04-07 00:26:29]

Description was changed from

==========
DevTools: Allow tab key to move focus when ConsolePrompt is empty

BUG=706699
==========

to

==========
DevTools: Allow tab key to move focus when ConsolePrompt is empty

When navigating with keyboard, focus would get stuck in the ConsolePrompt.

BUG=706699
==========

[einbinder, 2017-04-07 00:26:37]

The CQ bit was checked by einbinder@chromium.org

[commit-bot: I haz the power, 2017-04-07 00:27:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 05:27:40]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491524797035570, "parent_rev":
"3d9a196e23ef92fd8a270e31da6b2bf06d9609b6", "commit_rev":
"e917c881c0102a752c52210df377116220b79733"}

[commit-bot: I haz the power, 2017-04-07 05:28:27]

Description was changed from

==========
DevTools: Allow tab key to move focus when ConsolePrompt is empty

When navigating with keyboard, focus would get stuck in the ConsolePrompt.

BUG=706699
==========

to

==========
DevTools: Allow tab key to move focus when ConsolePrompt is empty

When navigating with keyboard, focus would get stuck in the ConsolePrompt.

BUG=706699

Review-Url: https://codereview.chromium.org/2802963002
Cr-Commit-Position: refs/heads/master@{#462769}
Committed:
https://chromium.googlesource.com/chromium/src/+/e917c881c0102a752c52210df377...
==========

[commit-bot: I haz the power, 2017-04-07 05:28:29]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e917c881c0102a752c52210df377...