Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2802953002: Avoid duplicate functions/code in core/editing: computeDistance (Closed)

Created:
3 years, 8 months ago by Daniel Bratell
Modified:
3 years, 8 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid duplicate functions/code in core/editing: computeDistance While experimenting with unity builds I encountered a few duplicate symbols and functions in core/editing. This patch renames, moves and unifies them. Several classes use computeDistanceToLeftGraphemeBoundary and instead of copying the whole function, make a single copy in EditingUtilities. Also move computeDistanceToRightGraphemeBoundary since those two functions are too similar to split up. BUG=708949 R=yosin@chromium.org Review-Url: https://codereview.chromium.org/2802953002 Cr-Commit-Position: refs/heads/master@{#462420} Committed: https://chromium.googlesource.com/chromium/src/+/b6ba28d755eb8cbcc5dba2f414d10cd2e434f6d8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -52 lines) Patch
M third_party/WebKit/Source/core/editing/EditingUtilities.h View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingUtilities.cpp View 1 chunk +26 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 1 chunk +0 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertIncrementalTextCommand.cpp View 2 chunks +0 lines, -26 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Daniel Bratell
Please take a look.
3 years, 8 months ago (2017-04-06 07:45:19 UTC) #2
yosin_UTC9
lgtm
3 years, 8 months ago (2017-04-06 09:58:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802953002/1
3 years, 8 months ago (2017-04-06 09:59:13 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 11:15:48 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b6ba28d755eb8cbcc5dba2f414d1...

Powered by Google App Engine
This is Rietveld 408576698