Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2802933003: Remove AudioManager::GetDefaultOutputStreamParameters() calls from AudioOutputDelegate unit tests. (Closed)

Created:
3 years, 8 months ago by o1ka
Modified:
3 years, 8 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org, audio-mojo-cl_google.com
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove AudioManager::GetDefaultOutputStreamParameters() calls from AudioOutputDelegate unit tests. BUG=672468 Review-Url: https://codereview.chromium.org/2802933003 Cr-Commit-Position: refs/heads/master@{#462468} Committed: https://chromium.googlesource.com/chromium/src/+/ebd3c9846d8a2340d947fae30220d607d95eae7c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M content/browser/renderer_host/media/audio_output_delegate_impl_unittest.cc View 12 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
o1ka
Max - PTAL
3 years, 8 months ago (2017-04-06 11:21:20 UTC) #5
Max Morin
lgtm
3 years, 8 months ago (2017-04-06 11:32:51 UTC) #6
o1ka
Thanks Max. guidou@chromium.org: Could you RS? Thanks!
3 years, 8 months ago (2017-04-06 12:06:53 UTC) #10
Guido Urdaneta
rs lgtm
3 years, 8 months ago (2017-04-06 14:32:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802933003/1
3 years, 8 months ago (2017-04-06 14:37:34 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 14:43:54 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ebd3c9846d8a2340d947fae30220...

Powered by Google App Engine
This is Rietveld 408576698