Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issue 2802923003: Fix SSL Connection Error metrics (Closed)

Created:
3 years, 8 months ago by svaldez
Modified:
3 years, 8 months ago
Reviewers:
Steven Holte
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix SSL Connection Error metrics The original metrics used units instead of enum. BUG=699226 Review-Url: https://codereview.chromium.org/2802923003 Cr-Commit-Position: refs/heads/master@{#462657} Committed: https://chromium.googlesource.com/chromium/src/+/2d7e2d37fded9c962ba2f3a708d10bba1237d373

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M tools/metrics/histograms/histograms.xml View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
svaldez
jochen: Could you provide OWNERS stamp to fix the units on this metric.
3 years, 8 months ago (2017-04-06 17:16:48 UTC) #2
svaldez
holte: Can you provide OWNERS stamp.
3 years, 8 months ago (2017-04-06 17:21:32 UTC) #4
Steven Holte
lgtm
3 years, 8 months ago (2017-04-06 20:25:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802923003/1
3 years, 8 months ago (2017-04-06 20:34:31 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 22:40:13 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2d7e2d37fded9c962ba2f3a708d1...

Powered by Google App Engine
This is Rietveld 408576698