third_party/WebKit/Source/core/page/PrintContext.cpp - Issue 2802903002: Move PrintBrowser from SPV2 to SPV1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/PrintContext.cpp

Issue 2802903002: Move PrintBrowser from SPV2 to SPV1 (Closed)

Patch Set: Only call PrintContext::end() if we are exiting Print mode not PrintBrowser mode Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/PrintContext.cpp

diff --git a/third_party/WebKit/Source/core/page/PrintContext.cpp b/third_party/WebKit/Source/core/page/PrintContext.cpp

index e88fd38599e162a4fd98c01cee87e5ed16616fcb..6999047c728ed8b1f90db2c9f3942d00a4fcf2e8 100644

--- a/third_party/WebKit/Source/core/page/PrintContext.cpp

+++ b/third_party/WebKit/Source/core/page/PrintContext.cpp

@@ -45,7 +45,7 @@ PrintContext::PrintContext(LocalFrame* frame)

: m_frame(frame), m_isPrinting(false), m_linkedDestinationsValid(false) {}

PrintContext::~PrintContext() {

- if (m_isPrinting)

+ if (m_isPrinting && !RuntimeEnabledFeatures::printBrowserEnabled())

pdr. 2017/04/10 00:24:34 Ditto here. I think we should remove the changes t

end();

}