third_party/WebKit/Source/core/frame/FrameView.cpp - Issue 2802903002: Move PrintBrowser from SPV2 to SPV1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2802903002: Move PrintBrowser from SPV2 to SPV1 (Closed)

Patch Set: Only call PrintContext::end() if we are exiting Print mode not PrintBrowser mode Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/FrameView.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp

index fc031a82fd5e5cc7d1038f35ed2e5e08021f4d00..35055778a11322d344c0983656e90dbc0a20eae7 100644

--- a/third_party/WebKit/Source/core/frame/FrameView.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp

@@ -2966,7 +2966,6 @@ void FrameView::setupPrintContext() {

void FrameView::clearPrintContext() {

if (!m_printContext)

return;

- m_printContext->end();

pdr. 2017/04/10 00:24:34 Did you mean to remove this? I think we still want

m_printContext.clear();

}