Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2802863005: Add owners for new omnibox metrics. (Closed)

Created:
3 years, 8 months ago by Bryan McQuade
Modified:
3 years, 8 months ago
Reviewers:
Ilya Sherman, lpy, Mark P
CC:
asvitkine+watch_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add owners for new omnibox metrics. These were mistakenly left out of https://codereview.chromium.org/2744983002 Note that, without an owner, metrics do not show up in the UMA dash by default, so it's important that we have owners for all metrics that we intend to use. lpy and mpearson, I'm happy to add myself as a third owner on these if you prefer. BUG=702440 Review-Url: https://codereview.chromium.org/2802863005 Cr-Commit-Position: refs/heads/master@{#462512} Committed: https://chromium.googlesource.com/chromium/src/+/02b1616fb612bfde61b74086016a66230fb41cea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 10 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Bryan McQuade
PTAL, thanks!
3 years, 8 months ago (2017-04-06 14:33:49 UTC) #4
Mark P
lgtm
3 years, 8 months ago (2017-04-06 15:57:10 UTC) #8
lpy
lgtm
3 years, 8 months ago (2017-04-06 16:31:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802863005/1
3 years, 8 months ago (2017-04-06 16:39:32 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 16:54:38 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/02b1616fb612bfde61b74086016a...

Powered by Google App Engine
This is Rietveld 408576698