Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2802863004: Improve error message of //tools/licenses.py. (Closed)

Created:
3 years, 8 months ago by Hiroshi Ichikawa
Modified:
3 years, 8 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, Eugene But (OOO till 7-30)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve error message of //tools/licenses.py. Current error message doesn't tell me which directory causes the error. Review-Url: https://codereview.chromium.org/2802863004 Cr-Commit-Position: refs/heads/master@{#462791} Committed: https://chromium.googlesource.com/chromium/src/+/32894e2ba3cd5d7a57d9160326d210205df7a861

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/licenses.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Hiroshi Ichikawa
3 years, 8 months ago (2017-04-06 04:58:13 UTC) #2
Paweł Hajdan Jr.
LGTM
3 years, 8 months ago (2017-04-06 11:52:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802863004/1
3 years, 8 months ago (2017-04-07 01:48:38 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 06:11:34 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/32894e2ba3cd5d7a57d9160326d2...

Powered by Google App Engine
This is Rietveld 408576698