Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Issue 2802853002: Revert of media: Simplify CdmHostFile(s) (Closed)

Created:
3 years, 8 months ago by xhwang
Modified:
3 years, 8 months ago
CC:
chromium-reviews, chfremer+watch_chromium.org, eme-reviews_chromium.org, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of media: Simplify CdmHostFile(s) (patchset #4 id:60001 of https://chromiumcodereview.appspot.com/2773283002/ ) Reason for revert: This issue is in the blame list of issue 708410. Though I don't really see how this could cause that failure, we decided to revert this for now to rule out possibilities. If we confirmed this is not the cause I'll reland it. BUG=708410 Original issue's description: > media: Simplify CdmHostFile(s) > > Today if any files are missing we close files immediately. This resulted in many complicated logic and requires a special command-line switch for testing. > > This CL simplifies the implementation by not treating missing files specially. When a file or a sig file is missing, an invalid file descriptor (e.g. -1 on posix) will be passed to the CDM. The CDM already has logic to deal with this case. > > This will also be useful in the future when we explore other ways to verify CDM host files. > > BUG=694707 > TEST=Updated browser test. > > Review-Url: https://codereview.chromium.org/2773283002 > Cr-Commit-Position: refs/heads/master@{#461193} > Committed: https://chromium.googlesource.com/chromium/src/+/e23c1b6375d994f06ed745805ba3847e8218cdba TBR=hmchen@chromium.org,kerrnel@chromium.org,alexmos@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=694707 Review-Url: https://codereview.chromium.org/2802853002 Cr-Commit-Position: refs/heads/master@{#462294} Committed: https://chromium.googlesource.com/chromium/src/+/4dae691b744caea02124a6d3f295c70f5cea9910

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -81 lines) Patch
M chrome/browser/media/encrypted_media_browsertest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/zygote_host/zygote_communication_linux.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M content/common/media/cdm_host_file.cc View 2 chunks +27 lines, -6 lines 0 comments Download
M content/common/media/cdm_host_files.h View 1 chunk +11 lines, -7 lines 0 comments Download
M content/common/media/cdm_host_files.cc View 7 chunks +97 lines, -46 lines 0 comments Download
M media/base/media_switches.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/base/media_switches.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M media/cdm/ppapi/external_clear_key/clear_key_cdm.cc View 2 chunks +4 lines, -22 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
xhwang
Created Revert of media: Simplify CdmHostFile(s)
3 years, 8 months ago (2017-04-05 22:24:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2802853002/1
3 years, 8 months ago (2017-04-05 22:25:38 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 00:35:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4dae691b744caea02124a6d3f295...

Powered by Google App Engine
This is Rietveld 408576698